Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ESLint 7, drop support ESLint 5 #774

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented May 19, 2020

EDIT: Ok so ESLint 7 is not compatible with Node 11.
This version is in end of life (End-of-Life releasese, should we drop support for Node 11 too? And maybe add support for Node 13 and Node 14?
WDYT?

EDIT 2: PR opened at #775

EDIT 3: PR rebased since #775 has been merged

@Rodrigo001-dev

This comment has been minimized.

@Kocal
Copy link
Contributor Author

Kocal commented Jul 31, 2020

PR rebased since #775 has been merged.
The failing test is unrelated I guess.

@Kocal Kocal force-pushed the feat/eslint-7 branch 2 times, most recently from b4003d9 to f60418a Compare September 10, 2020 05:01
@weaverryan weaverryan changed the base branch from master to main November 18, 2020 18:19
@weaverryan
Copy link
Member

Thanks @Kocal!

@weaverryan weaverryan merged commit 9f24246 into symfony:main Dec 3, 2020
@Kocal Kocal deleted the feat/eslint-7 branch December 3, 2020 15:18
@Kocal Kocal mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants