-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgraded ts-loader to ^8.0.1 #800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0.0 was released a week ago, maybe we should go for that one instead?
Also, should we allow multiple versions instead of only the latest one? This would avoid forcing people to upgrade, especially since 8.0.0 does not seem to be compatible with Typescript 2.x anymore.
9058dee
to
132ed55
Compare
Typescript 2.x is EOLed since years. |
Thanks @skmedix! |
Using newer loader will cause encore throw a warning message about using too new version. However this PR doesn't seem to make any other changes than Did you double check this will also remove the warning message posted during build? |
The
|
If I want use new ts-loader version what I should upgrade? |
Actually, ts-loader should directly be in YOUR package.json file, so you can upgrade it directly - that’s all you need :) |
Thanks @weaverryan for fast response... But when I think about it now... I can actually update both :) I was just wondering if it enough to update only the npm module, or do I need to update composer package as well. PS. I love your tutorials ;) |
Resolves #703
Tests: ✔️ Node 10 | ✔️ Node 12