Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator should allow copyFiles() without other entries. #831

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Validator should allow copyFiles() without other entries. #831

merged 1 commit into from
Dec 3, 2020

Conversation

pszalko
Copy link
Contributor

@pszalko pszalko commented Aug 28, 2020

Fix for #830

@pszalko pszalko marked this pull request as ready for review August 28, 2020 21:29
Lyrkan
Lyrkan requested changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pszalko,

Thanks for the PR, I think it would be a nice thing to have :)

I only have a small comment regarding the test you added.

test/index.js Outdated Show resolved Hide resolved
Lyrkan
Lyrkan reviewed Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last really minor comment before approving :)

test/config/validator.js Outdated Show resolved Hide resolved
@weaverryan weaverryan changed the base branch from master to main November 18, 2020 18:17
@weaverryan
Copy link
Member

Thank you @pszalko!

@weaverryan weaverryan merged commit a11348c into symfony:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyrkan Lyrkan Lyrkan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pszalko @weaverryan @Lyrkan