Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing manifest paths (by temporarily embedding webpack-manifest-plugin fix) #921

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

weaverryan
Copy link
Member

This temporarily embeds shellscape/webpack-manifest-plugin#249, which fixes #907 and also a comment on #914 (comment)

To test this:

$ yarn remove @symfony/webpack-encore
$ yarn add git://github.com/weaverryan/webpack-encore.git#try-manifest-fix

Please let me know if this does or doesn't fix your manifest.json file. I'm also interested in hearing from Windows users, as the fix requires some "path" manipulation.

Thanks!

@minimit
Copy link
Contributor

minimit commented Feb 8, 2021

Works great on mac, can't test on windows

@weaverryan
Copy link
Member Author

Thanks @shellscape for keeping an eye on that ;). I did include it in the new webpack-manifest-plugin directory - I grabbed the LICENSE file from master and put it there - https://github.com/symfony/webpack-encore/pull/921/files#diff-1422c8fd28cafc7a2c9bb9bfba27c0a1598d225ced0644653c1226bbd48604e7 - but let me know if it needs to be somewhere else.

Btw, this embedding I hope is temporary, at best :). I want to get the fix out to our users ASAP because I don't want users to start relying on the new incorrect paths... only for us to change them back later.

@weaverryan weaverryan force-pushed the try-manifest-fix branch 4 times, most recently from d3313e0 to 2552104 Compare February 9, 2021 02:19
@weaverryan weaverryan changed the title [WIP] Testing the webpack-manifest-plugin fix Fixing manifest paths (by temporarily embedding webpack-manifest-plugin fix) Feb 9, 2021
@weaverryan
Copy link
Member Author

This is now ready to go. We may never merge it - it depends on shellscape/webpack-manifest-plugin#249 - I'd like to merge and tag a fix ASAP for people. We could always remove this "embedded" plugin easily and re-add the real one.

Cheers!

@weaverryan weaverryan force-pushed the try-manifest-fix branch 4 times, most recently from 19e3bd9 to 6ae04be Compare February 11, 2021 02:03
@weaverryan
Copy link
Member Author

I've fully embedded the fix from shellscape/webpack-manifest-plugin#249

I'm confident that I now have the problem solved correctly there. I'd like to get this fix to our users, so I'm planning to merge this PR and temporarily embed the plugin so we can get it released :).

Cheers!

@weaverryan weaverryan merged commit 9847ea6 into symfony:main Feb 12, 2021
@weaverryan weaverryan deleted the try-manifest-fix branch February 12, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.0 problems in manifest.json when importing from composer vendor folder
2 participants