Fix Encore.copyFiles() when copying images/fonts #930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that prevented
Encore.copyFiles()
from working properly when copying files that matched one of the defaultasset/resource
rules.Note that it has two drawbacks:
configureLoaderRule('images', ...)
orconfigureLoaderRule('fonts', ...)
since it adds a newoneOf
at the top-level of each ruleEncore.copyFiles(...)
they'll have to use the sameoneOf
/resourceQuery
pattern to avoid conflictsCloses #894