Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Encore.copyFiles() when copying images/fonts #930

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Feb 12, 2021

This PR fixes an issue that prevented Encore.copyFiles() from working properly when copying files that matched one of the default asset/resource rules.

Note that it has two drawbacks:

  • it introduces what could be considered as a small breaking change for users calling configureLoaderRule('images', ...) or configureLoaderRule('fonts', ...) since it adds a new oneOf at the top-level of each rule
  • if an user create a new rule that also matches files handled by Encore.copyFiles(...) they'll have to use the same oneOf/resourceQuery pattern to avoid conflicts

Closes #894

@weaverryan
Copy link
Member

Thank you for checking into this complex bug @Lyrkan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copyFiles() error after 1.0 upgrade
2 participants