fix: don't override process variable in DefinePlugin configuration

[drazik]

Following the warning on https://webpack.js.org/plugins/define-plugin/:

When defining values for process prefer
'process.env.NODE_ENV': JSON.stringify('production') over
process: { env: { NODE_ENV: JSON.stringify('production') } }.
Using the latter will overwrite the process object which can break
compatibility with some modules that expect other values on the
process object to be defined.

This fixed a conflict warning I had when using dotenv-webpack plugin:

DefinePlugin
Conflicting values for 'process.env'

[weaverryan]

Hey @drazik!

This seems to make sense - thank you. However, there are some tests that are failing on Travis. with an error about not being able to read NODE_ENV from undefined. Can you take a look?

Thanks!

[Kocal]

Should be this considered as a breaking change? Or at least being documented in a changelog?

At work we use the following code to inject SENTRY_DSN and SENTRY_ENVIRONMENT env vars in the bundle (from a .env file or from process.env):

Encore
  .configureDefinePlugin((options) => {
    const dotenvEnv = dotenv.config();
    if (dotenvEnv.error) {
      throw dotenvEnv.error;
    }

    const env = { ...dotenvEnv.parsed, ...process.env };

    ['SENTRY_DSN', 'SENTRY_ENVIRONMENT'].forEach((envVar) => {
      options['process.env'][envVar] = JSON.stringify(env[envVar]);
    });
  })

And I guess it won't works until we change options['process.env'][envVar] to options['process.env.' + envVar] right?
WDYT?

Thanks

[drazik]

@weaverryan I fixed most of the test. One of them is still failing but I don't understand if it's related to my changes or not. And if it is related to my changes, what can I do about it?

@Kocal you are totally right, this is a breaking change for people that customize the DefinePlugin like you do. And you are also right about the changes it requires in your case.

[weaverryan]

Due to the breaking change (good catch), I'd love to stuff this into a new major release instead of a minor.

[weaverryan]

Thank you @drazik!