Locking assets-webpack-plugin to less than 7.1.0 #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztoben/assets-webpack-plugin#392 makes our integrity calculation no longer work, as the files have not been emitted by the time processOutput() is called. A better fix will need to be created.
stof
approved these changes
Apr 28, 2021
zairigimad
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ztoben/assets-webpack-plugin#392 makes our integrity calculation no longer work, as the files have not been emitted by the time processOutput() is called.
A better fix will need to be created. I'll create an issue after merging this for that.
The most obvious would be to - if possible - use the existing https://github.com/ztoben/assets-webpack-plugin#integrity
If it IS possible (I don't know if it exposes all the same info we do), then we would need to deprecate the current format of the entrypoints.json file in favor of this new one.