Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve security issue CVE-2021-23369 #975

Merged
merged 1 commit into from
May 7, 2021

Conversation

elghailani
Copy link
Contributor

This PR resolve the newly published critical security issue CVE-2021-23369 : Remote code execution in handlebars when compiling templates

package.json Outdated Show resolved Hide resolved
@Kocal
Copy link
Member

Kocal commented May 7, 2021

And resync the yarn.lock for applying your last changes on the package.json! :)

@weaverryan
Copy link
Member

Hi!

Just a clarification for anyone else: this is a require-dev dependency - there is no security issue with Encore. If you are using handlebars in your app, then you have it installed directly and need to manage its version independent of Encore :).

But I will merge this (when it's ready - the lock file needs to be updated and recommitted) - it will help recommend to people that their version is lower than what we support.

@elghailani
Copy link
Contributor Author

Thanks @Kocal & @weaverryan for the feedbacks.
The lock file is synched.

@weaverryan
Copy link
Member

Thanks for putting this together @elghailani!

@weaverryan weaverryan merged commit 2dc37ae into symfony:main May 7, 2021
@elghailani elghailani deleted the CVE-2021-23369-fix branch May 7, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants