Add to_angle for the Rot2 class

[hflemmen]

I suggest adding a convenience function to get the angle from a 2D rotation. It complements the existing from_angle, and is intuitive to use when working with 2D rotation angles.

[aaron-skydio]

Cool, yeah I think this is a good thing to have

[aaron-skydio]

I think this should just call to_tangent to avoid duplicating the implementation, like from_angle does with from_tangent

[hflemmen]

That makes sense, I changed it now.

[hflemmen]

It seems like it fails the lint checks. Do you have a special linter format?

[aaron-skydio]

You need a type annotation for epsilon: T.Scalar:

symforce/geo/rot2.py:140: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]

You can run the linter with make lint (it's just black, mypy, and pylint with the configurations in pyproject.toml and pylintrc)

[hflemmen]

Thank you for the explanation. make lint did not work for me, possibly due to the issue with python 3.10.7, which is mentioned in the test case. I added the scalar type for epsilon.

[aaron-skydio]

Looks like the thing that's failing now is the autoformat - make format should work fine on py3.10, or you can just copy-paste the suggested change

[hflemmen]

make format changed a lot of files that I have not touched. Should I commit those as well?

[aaron-skydio]

No - everything that make format should format is checked by CI - most likely that means you have a different version of black than we use (21.12b0, from setup.py). If you're on the same version of black and see other files changed that would be good to know about though, I'd be curious what the changes are

[hflemmen]

True, i used black version 23.7.0.

There are rather many files that are affected, but mostly for the same reasons:

• Add spaces around ** operators.
• Remove blank line after :.
• Remove parenthesis around tuples in for loops. E.g. for (expr, name) in self.override_methods.items(): -> for expr, name in self.override_methods.items():

After revering to the correct version of black, the two latter ones were not undone, so I guess that it accepts both versions.

[hflemmen]

Now that all checks have passed, is there more I need to do before the review is passed and it can be merged?

[aaron-skydio]

True, i used black version 23.7.0.

There are rather many files that are affected, but mostly for the same reasons:

* Add spaces around `**` operators.

* Remove blank line after `:`.

* Remove parenthesis around tuples in for loops. E.g. `for (expr, name) in self.override_methods.items():` -> `for expr, name in self.override_methods.items():`

After revering to the correct version of black, the two latter ones were not undone, so I guess that it accepts both versions.

Thanks, makes sense

Now that all checks have passed, is there more I need to do before the review is passed and it can be merged?

Nothing more you need to do, I'll merge it