Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Config Breaks Web GUI Post #1104

Closed
olivov opened this issue Jan 29, 2021 · 1 comment · Fixed by #1105
Closed

Default Config Breaks Web GUI Post #1104

olivov opened this issue Jan 29, 2021 · 1 comment · Fixed by #1105
Labels
Milestone

Comments

@olivov
Copy link
Contributor

olivov commented Jan 29, 2021

The use_html_editor config option by default is set to 'off'. In 6.2.60, this appears to break the logic for whether or not a message posted throught the Sympa web interface should be text/plain or text/html. The particular block that I believe is the pain point:

sympa/src/cgi/wwsympa.fcgi.in

Lines 14869 to 14876 in 3392c83

if (Conf::get_robot_conf($robot, 'use_html_editor')) {
$msg_string .= sprintf "Content-Type: text/html\n\n%s",
$in{'body'};
} else {
$msg_string .= sprintf "Content-Type: text/plain\n\n%s",
$in{'body'};
}
$msg_string =~ s/(?<!\n)\z/\n/;

Our current config has use_html_editor commented out and uses the default value of 'off' which causes messages posted from the web interface to be sent out as 'text/html' and mucks with newlines in the text.

Version

6.2.60

Installation method

Source

Expected behavior

Messages posted through the web interface should be sent as 'text/plain' when use_html_editor is set to off or 0.

Actual behavior

Messages posted through the web interface are sent as 'text/html' when use_html_editor is set to 'off'.

@ikedas
Copy link
Member

ikedas commented Jan 30, 2021

Hi @olivov ,
This patch may fix the bug you reported. Could you please check it? This fix will be included in the next stable release.

@ikedas ikedas added this to the 6.2.62 milestone Jan 30, 2021
ikedas added a commit that referenced this issue Feb 6, 2021
Default config breaks web GUI post (#1104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants