Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache error_log noise [just a nit] #1185

Closed
dpc22 opened this issue Jun 7, 2021 · 1 comment · Fixed by #1187
Closed

Apache error_log noise [just a nit] #1185

dpc22 opened this issue Jun 7, 2021 · 1 comment · Fixed by #1187
Labels
Milestone

Comments

@dpc22
Copy link
Contributor

dpc22 commented Jun 7, 2021

Version

6.2.62

Installation method

My own RPM, derived from official source RPM for RHEL 7

Expected behavior

Apache error_log should be empty

Actual behavior

Apache error logs contains assorted "uninitialized value" noise.

[Mon Jun 07 10:01:22.937160 2021] [proxy_fcgi:error] [pid 8371] [client XXX.XXX.XXX.XXX:58482] AH01071: Got error 'ne 1319.\nUse of uninitialized value $mode in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1319.\nUse of uninitialized value $mode in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1319.\nUse of uninitialized value $mode in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1319.\n'

[Mon Jun 07 10:01:46.411917 2021] [proxy_fcgi:error] [pid 8371] [client XXX.XXX.XXX.XXX:58590] AH01071:
  Got error '31.\nUse of uninitialized value $format in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1531.\nUse of uninitialized value $format in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1531.\nUse of uninitialized value $format in string eq at /usr/share/sympa/lib/Sympa/WWW/SOAP.pm line 1531.\n'

[Mon Jun 07 10:42:26.133854 2021] [proxy_fcgi:error] [pid 11355] [client XXX.XXX.XXX.XXX:60061] AH01071: Got error 'Use of uninitialized value in string ne at /usr/share/sympa/lib/Sympa/Spindle/AuthorizeRequest.pm line 118.\n', referer: https://lists.cam.ac.uk/sympa/create_list_request

[Mon Jun 07 10:45:26.665123 2021] [proxy_fcgi:error] [pid 11355] [client XXX.XXX.XXX.XXX:60077] AH01071: Got error 'match (m//) at /usr/share/sympa/lib/Sympa/Config.pm line 503.\nUse of uninitialized value in string eq at /usr/share/sympa/lib/Sympa/Config.pm line 584.\nUse of uninitialized value in pattern match (m//) at /usr/share/sympa/lib/Sympa/Config.pm line 533.\nUse of uninitialized value in pattern match (m//) at /usr/share/sympa/lib/Sympa/Config.pm line 533.\n', referer: https://lists.cam.ac.uk/sympa

Quite a lot of noise in the two SOAP.pm cases:

$ fgrep -c 'SOAP.pm' /var/log/httpd/error_log
2380
$ fgrep -c 'Config.pm' /var/log/httpd/error_log
19
$ fgrep -c 'AuthorizeRequest.pm' /var/log/httpd/error_log
1

Additional information

I attach a patch which just adds defined($foo) to each of the tests. It is possible that you would prefer a pull request instead.

undefined.patch.txt

Obviously not very important in the grand scheme of things, but it would be nice to get this fixed when 6.2.64 is released

@ikedas ikedas added the bug label Jun 7, 2021
ikedas added a commit to ikedas/sympa that referenced this issue Jun 8, 2021
@ikedas ikedas added this to the 6.2.64 milestone Jun 8, 2021
ikedas added a commit that referenced this issue Jun 8, 2021
@ikedas
Copy link
Member

ikedas commented Jun 8, 2021

Thanks for suggestion. The fixes will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants