Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incomplete example intranet scenario #119

Closed
xavierba opened this issue Nov 8, 2017 · 8 comments · Fixed by #800
Closed

Remove incomplete example intranet scenario #119

xavierba opened this issue Nov 8, 2017 · 8 comments · Fixed by #800
Labels
bug design ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@xavierba
Copy link
Contributor

xavierba commented Nov 8, 2017

According to @ikedas, intranet scenario are incomplete examples and should not be used.
This would mean removing the following files :
default/create_list_templates/intranet_list/comment.tt2
default/create_list_templates/intranet_list/config.tt2
default/create_list_templates/intranet_list/
default/scenari/access_web_archive.intranet
default/scenari/create_list.intranet
default/scenari/review.intranet
default/scenari/send.intranet
default/scenari/send.intranetorprivate
default/scenari/subscribe.intranet
default/scenari/subscribe.intranetorowner
default/scenari/visibility.intranet

@racke
Copy link
Contributor

racke commented Nov 24, 2017

Can you please elaborate why they are incomplete? Some people might already use them.

@ikedas
Copy link
Member

ikedas commented Nov 24, 2017

It's about customization I made on rpm spec. I remember why I did it.

Intranet scenarios does not always work as expected (see default/scenari/*.intranet* scenarios: E.g. host names list.example.org and client.example.org never match), and they have to be modified on many sites. However, they are enabled by default and confused several users.

So I thought they would be better to be removed, moved to doc/smaples, or (as I did in spec above) disabled by default.

@qosobrin
Copy link
Contributor

I absolutely agree with the removal. In my humble opinion a better solution would be the one I proposed in #171: implement a text box where the owners could add a list of domains from where the list could be added, viewed, etc.

@ikedas
Copy link
Member

ikedas commented Apr 4, 2018

If there are no objections in this week, files above will be removed from source tree.

@xavierba
Copy link
Contributor Author

xavierba commented Apr 4, 2018

Would it make sense to move the files to doc/samples ? That would be my preferred choice, but I'm fine with having the files removed.

@ikedas
Copy link
Member

ikedas commented Apr 5, 2018

I'm reviewing intranet scenarios, and found they imply many weird behaviors. For example, archive_web_access.intranet:

title.gettext restricted to local domain users

is_subscriber([listname],[sender])         md5,smime  -> do_it
is_listmaster([sender])                    md5,smime  -> do_it
match ([env->remote_host],/[conf->host]$/) md5,smime  -> do_it
match([sender],/[conf->host]$/)            md5,smime  -> do_it
true()                                     md5,smime  -> reject(reason='web_archive_local_user_sub')
  • This scenario is used only by web interface. As is_subscriber() and is_listmaster() fail with anonymous (unauthenticated) users, md5,smime in the first and second rules are unnecessary.
  • The first and second match() unexpectedly fail in some cases, e.g. REMOTE_HOST client.example.org and host parameter list.example.org.
  • The first and second match() unexpectedly succeed in some cases, e.g. user@surrealist.example.org and list.example.org.
  • If user has not logged in, they may be informed error instead of rejection message.

I suppose we would be better to do away with these scenarios rather than keeping them as samples.

@ikedas
Copy link
Member

ikedas commented Apr 23, 2018

I wrote description with some revised scenarios (unverified).

@ikedas
Copy link
Member

ikedas commented Nov 13, 2019

I decided to postpone correction of current intranet scenarios: They will be moved to doc/samples/intranet.:

doc/samples/intranet/create_list_templates/intranet_list/comment.tt2
doc/samples/intranet/create_list_templates/intranet_list/config.tt2
doc/samples/intranet/scenari/archive_web_access.intranet
doc/samples/intranet/scenari/create_list.intranet
doc/samples/intranet/scenari/review.intranet
doc/samples/intranet/scenari/send.intranet
doc/samples/intranet/scenari/send.intranetorprivate
doc/samples/intranet/scenari/subscribe.intranet
doc/samples/intranet/scenari/subscribe.intranetorowner
doc/samples/intranet/scenari/visibility.intranet

@ikedas ikedas added ready A PR is waiting to be merged. Close to be solved and removed question labels Nov 13, 2019
@ikedas ikedas added this to the 6.2.50 milestone Nov 13, 2019
ikedas added a commit that referenced this issue Nov 19, 2019
ikedas added a commit to ikedas/sympa that referenced this issue Nov 19, 2019
ikedas added a commit to sympa-community/sympa-community.github.io that referenced this issue Nov 19, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Apr 27, 2020
* Security and bug fixes
* more translations
* Some scenarios and list creation templates for "intranet" use cases were
  made optional: They have been moved into samples/
  sympa-community/sympa#119
  See also "upgrading notes" (https://sympa-community.github.io/manual/upgrade/notes.html#from-version-prior-to-6250)
  for details.
* Hide full email addresses in archives
* Button for full export of subscribers
* Admin function to bulk unsubscribe
* Delete my account" button
* ARC support (Authenticated Received Chain).
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 9, 2020
mail/sympa: security fix

Revisions pulled up:
- mail/sympa/Makefile                                           1.75-1.76
- mail/sympa/PLIST                                              1.16-1.17
- mail/sympa/distinfo                                           1.20-1.21
- mail/sympa/patches/patch-aa                                   1.10
- mail/sympa/patches/patch-ab                                   1.8
- mail/sympa/patches/patch-ac                                   1.6

---
   Module Name:    pkgsrc
   Committed By:   bouyer
   Date:           Mon Apr 27 17:57:52 UTC 2020

   Modified Files:
           pkgsrc/mail/sympa: Makefile PLIST distinfo
           pkgsrc/mail/sympa/patches: patch-aa patch-ab patch-ac

   Log Message:
   Update to 6.2.54. Main changes since 6.2.16:
   * Security and bug fixes
   * more translations
   * Some scenarios and list creation templates for "intranet" use cases were
     made optional: They have been moved into samples/
     sympa-community/sympa#119
     See also "upgrading notes" (https://sympa-community.github.io/manual/upgrade/notes.html#from-version-prior-to-6250)
     for details.
   * Hide full email addresses in archives
   * Button for full export of subscribers
   * Admin function to bulk unsubscribe
   * Delete my account" button
   * ARC support (Authenticated Received Chain).

---
   Module Name:	pkgsrc
   Committed By:	bouyer
   Date:		Mon Jun  1 21:46:25 UTC 2020

   Modified Files:
   	pkgsrc/mail/sympa: Makefile PLIST distinfo

   Log Message:
   Update to 6.2.56. Changes since 6.2.54:
   Security fix for https://sympa-community.github.io/security/2020-002.html
   Translation updates
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Oct 14, 2021
mail/sympa: security fix

Revisions pulled up:
- mail/sympa/Makefile                                           1.75-1.76
- mail/sympa/PLIST                                              1.16-1.17
- mail/sympa/distinfo                                           1.20-1.21
- mail/sympa/patches/patch-aa                                   1.10
- mail/sympa/patches/patch-ab                                   1.8
- mail/sympa/patches/patch-ac                                   1.6

---
   Module Name:    pkgsrc
   Committed By:   bouyer
   Date:           Mon Apr 27 17:57:52 UTC 2020

   Modified Files:
           pkgsrc/mail/sympa: Makefile PLIST distinfo
           pkgsrc/mail/sympa/patches: patch-aa patch-ab patch-ac

   Log Message:
   Update to 6.2.54. Main changes since 6.2.16:
   * Security and bug fixes
   * more translations
   * Some scenarios and list creation templates for "intranet" use cases were
     made optional: They have been moved into samples/
     sympa-community/sympa#119
     See also "upgrading notes" (https://sympa-community.github.io/manual/upgrade/notes.html#from-version-prior-to-6250)
     for details.
   * Hide full email addresses in archives
   * Button for full export of subscribers
   * Admin function to bulk unsubscribe
   * Delete my account" button
   * ARC support (Authenticated Received Chain).

---
   Module Name:	pkgsrc
   Committed By:	bouyer
   Date:		Mon Jun  1 21:46:25 UTC 2020

   Modified Files:
   	pkgsrc/mail/sympa: Makefile PLIST distinfo

   Log Message:
   Update to 6.2.56. Changes since 6.2.54:
   Security fix for https://sympa-community.github.io/security/2020-002.html
   Translation updates
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jan 18, 2023
mail/sympa: security fix

Revisions pulled up:
- mail/sympa/Makefile                                           1.75-1.76
- mail/sympa/PLIST                                              1.16-1.17
- mail/sympa/distinfo                                           1.20-1.21
- mail/sympa/patches/patch-aa                                   1.10
- mail/sympa/patches/patch-ab                                   1.8
- mail/sympa/patches/patch-ac                                   1.6

---
   Module Name:    pkgsrc
   Committed By:   bouyer
   Date:           Mon Apr 27 17:57:52 UTC 2020

   Modified Files:
           pkgsrc/mail/sympa: Makefile PLIST distinfo
           pkgsrc/mail/sympa/patches: patch-aa patch-ab patch-ac

   Log Message:
   Update to 6.2.54. Main changes since 6.2.16:
   * Security and bug fixes
   * more translations
   * Some scenarios and list creation templates for "intranet" use cases were
     made optional: They have been moved into samples/
     sympa-community/sympa#119
     See also "upgrading notes" (https://sympa-community.github.io/manual/upgrade/notes.html#from-version-prior-to-6250)
     for details.
   * Hide full email addresses in archives
   * Button for full export of subscribers
   * Admin function to bulk unsubscribe
   * Delete my account" button
   * ARC support (Authenticated Received Chain).

---
   Module Name:	pkgsrc
   Committed By:	bouyer
   Date:		Mon Jun  1 21:46:25 UTC 2020

   Modified Files:
   	pkgsrc/mail/sympa: Makefile PLIST distinfo

   Log Message:
   Update to 6.2.56. Changes since 6.2.54:
   Security fix for https://sympa-community.github.io/security/2020-002.html
   Translation updates
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Dec 10, 2024
mail/sympa: security fix

Revisions pulled up:
- mail/sympa/Makefile                                           1.75-1.76
- mail/sympa/PLIST                                              1.16-1.17
- mail/sympa/distinfo                                           1.20-1.21
- mail/sympa/patches/patch-aa                                   1.10
- mail/sympa/patches/patch-ab                                   1.8
- mail/sympa/patches/patch-ac                                   1.6

---
   Module Name:    pkgsrc
   Committed By:   bouyer
   Date:           Mon Apr 27 17:57:52 UTC 2020

   Modified Files:
           pkgsrc/mail/sympa: Makefile PLIST distinfo
           pkgsrc/mail/sympa/patches: patch-aa patch-ab patch-ac

   Log Message:
   Update to 6.2.54. Main changes since 6.2.16:
   * Security and bug fixes
   * more translations
   * Some scenarios and list creation templates for "intranet" use cases were
     made optional: They have been moved into samples/
     sympa-community/sympa#119
     See also "upgrading notes" (https://sympa-community.github.io/manual/upgrade/notes.html#from-version-prior-to-6250)
     for details.
   * Hide full email addresses in archives
   * Button for full export of subscribers
   * Admin function to bulk unsubscribe
   * Delete my account" button
   * ARC support (Authenticated Received Chain).

---
   Module Name:	pkgsrc
   Committed By:	bouyer
   Date:		Mon Jun  1 21:46:25 UTC 2020

   Modified Files:
   	pkgsrc/mail/sympa: Makefile PLIST distinfo

   Log Message:
   Update to 6.2.56. Changes since 6.2.54:
   Security fix for https://sympa-community.github.io/security/2020-002.html
   Translation updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants