Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options for welcome_return_path & remind_return_path do not describe their function #1475

Closed
ikedas opened this issue Sep 9, 2022 · 0 comments · Fixed by #1476
Closed

Options for welcome_return_path & remind_return_path do not describe their function #1475

ikedas opened this issue Sep 9, 2022 · 0 comments · Fixed by #1476
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone
6.2.72

Comments

@ikedas
Copy link
Member

ikedas commented Sep 9, 2022

Version

Any (these parameters were introduced on Sympa 2.5).

Installation method

Any.

Expected behavior

Options for welcome_return_path and remind_return_path should express their function: If either of them enables VERP, bouncing users will immediately be deleted.

Actual behavior

Options are named "owner" and "unique", disabling and enabling VERP respectively.

Steps to reproduce

No steps are needed to reproduce.

Additional information

See also the PR submitted later.
@ikedas ikedas added the bug label Sep 9, 2022
ikedas added a commit to ikedas/sympa that referenced this issue Sep 9, 2022
@ikedas
Options for welcome_return_path & remind_return_path do not describe …
be7fa47 
…their function (sympa-community#1475)

  * Rename welcome_return_path & remind_return_path to verp_*.
  * Rename their options "owner" & "unique" to "off" and "on".
@ikedas ikedas mentioned this issue Sep 9, 2022
Merged
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Sep 9, 2022
@ikedas ikedas added this to the 6.2.72 milestone Sep 24, 2022
ikedas added a commit that referenced this issue Nov 15, 2022
@ikedas
Merge pull request #1476 from ikedas/rename_verp_parameters by ikedas
a55d39b 
Options for welcome_return_path & remind_return_path do not describe their function (#1475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Milestone
6.2.72
1 participant
@ikedas