Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of static_content and css directories #172

Closed
xavierba opened this issue Jan 25, 2018 · 5 comments
Closed

Location of static_content and css directories #172

xavierba opened this issue Jan 25, 2018 · 5 comments

Comments

@xavierba
Copy link
Contributor

xavierba commented Jan 25, 2018

Hi,

My understanding is the static_content name comes from the fact that it is statically served by the http server, while the remaining is served by cgi.
Most of what is installed in static_content directory is indeed data that does not change (fonts, javascripts) and thus can be installed readonly and owned by root user. This seems to fit well to $datadir$.
The only exception is the css subdirectory, which holds content dynamically generated by sympa and thus needs to be writeable by sympa user. As this is a subdirectory of static_content, this gets installed into $datadir$, but would seems to better fit into $localstatedir$.
I would suggest to split location of the css directory from the location of the static_content directory. The css directory could then be installed into $localstatedir$ while the static_content directory is installed into $datadir. This would probably mean the http conf needs to be tweaked to acknowledge for this change.

Does that make sense ?

Regards,
Xavier

@ikedas ikedas added the design label Feb 2, 2018
@ikedas
Copy link
Member

ikedas commented Feb 2, 2018

Hi Xavier,
I feel it making sense. Currently, default value of css_path parameter is derived from static_content_path parameter (it's STATICDIR by default). The former would have the default location of its own.

@xavierba
Copy link
Contributor Author

xavierba commented Feb 2, 2018

There is likely a similar issue with the pictures directory, which is located within staticdir too (and is also not created, like the css dir that got fixed with 85a6217)

@ikedas
Copy link
Member

ikedas commented Mar 3, 2018

Changes look done. I'll close this issue.

@ikedas
Copy link
Member

ikedas commented Mar 11, 2018

Reopened to fix bug described in PR above.

@ikedas ikedas reopened this Mar 11, 2018
ikedas added a commit that referenced this issue Mar 12, 2018
Fix bug by change of issue #172 by ikedas
@ikedas
Copy link
Member

ikedas commented Mar 12, 2018

Seems fixed. Close.

@ikedas ikedas closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants