Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check on "Digest frequency" #1742

Closed
fchaumontet opened this issue Nov 28, 2023 · 4 comments · Fixed by #1745
Closed

Missing check on "Digest frequency" #1742

fchaumontet opened this issue Nov 28, 2023 · 4 comments · Fixed by #1745
Labels

Comments

@fchaumontet
Copy link

Users can defined digest frequency with minutes = 99.
It make sympa process crash.
Attached files :

  • log extract corresponding to the crash in ProcessDigest.pm
  • print screen of Digest frequency define in the list configuration

Version

Sympa 6.2.68

Installation method

source package

Expected behavior

Integrate a value check in new release in the configuration screen
Add a value check in ProcessDigest.pm that log the list name

Steps to reproduce

Go to "Edit list Config" > "Sending/receiving setup"
Enter hour or/and minute out of range (27h99m for example)
Start sympa.

ListConfig-InvalidDigestFrequency
SympaLogExtract-hide.log

@ikedas
Copy link
Member

ikedas commented Nov 29, 2023

@fchaumontet , thank you for reporting bug!

Could you please apply this patch and check if the problem will be solved?

@fchaumontet
Copy link
Author

Hi,
We just try the patch.
It work for minutes but not for hours
image

@ikedas
Copy link
Member

ikedas commented Nov 29, 2023

Hi @fchaumontet ,
Sorry. Could you please apply additional patch and check again?

@fchaumontet
Copy link
Author

Hello,
It looks good.
Thanks for the patch.
Regards

racke added a commit that referenced this issue Dec 1, 2023
Missing validation on Digest frequency in Edit Config (#1742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants