Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting invite sender as From: violates modern sender authentication #1846

Closed
adam12b1 opened this issue May 28, 2024 · 1 comment · Fixed by #1882
Closed

Setting invite sender as From: violates modern sender authentication #1846

adam12b1 opened this issue May 28, 2024 · 1 comment · Fixed by #1882
Labels

Comments

@adam12b1
Copy link

Version

Sympa 6.2.72

Installation method

FreeBSD port

Expected behavior

Invite emails should successfully reach their destination.

Actual behavior

These invites will be filtered or blocked in many cases, because they are sending From: the person doing the invitation. Assuming that person's email is not hosted on the same system as the Sympa lists, sender authentication will fail.

Additional information

The fix (or one possible fix) is extremely simple: just remove the From: line from the mail_tt2/invite.tt2 file. That way, the invite will go out with the default Sympa administrative sender address, sympa@lists.domain.org (or whatever domain the Sympa server lives in), which will pass sender authentication checks.

# diff -c invite.tt2~ invite.tt2
*** invite.tt2~ Sun Mar 31 20:18:16 2024
--- invite.tt2  Tue May 28 16:04:12 2024
***************
*** 1,5 ****
  [%# invite.tt2 ~%]
- From: [% requested_by %]
  Reply-To: [% conf.email %]@[% domain %]
  Subject: [%"Invitation to join list %1"|loc(list.name)|qencode%]

--- 1,4 ----
@adam12b1 adam12b1 added the bug label May 28, 2024
@ikedas
Copy link
Member

ikedas commented Jun 19, 2024

Hi @adam12b1 , thank you for your contribution!
I'll review your changes and, if possible, will add something. Please wait for a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants