Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a list takes incredible time #368

Closed
finkyseb opened this issue Jul 6, 2018 · 6 comments
Closed

Rename a list takes incredible time #368

finkyseb opened this issue Jul 6, 2018 · 6 comments
Labels
Milestone

Comments

@finkyseb
Copy link

finkyseb commented Jul 6, 2018

Version

Sympa 6.2.32

Installation method

Source Package

Expected behavior

Rename a list via Web Interface or via the shell with sympa.pl

Actual behavior

The process to rename a list takes an incredible time.
In the web interface we receives an HTTP 500 error and via the shell (sympa.pl --rename_list) it works but takes lots of time.
We make a strace on the process and it seems to parse all the robots and list before to rename effectively the list.

Unistra team

@acexiis @finkyseb @jean1

Additional information

@ikedas
Copy link
Member

ikedas commented Jul 6, 2018

In Sympa::Request::Handler::move_list::_move(), all spools are scanned and their contents are renamed as necessity. During this process, each of directory entries is read and confirmed which list it belongs to (with $spool->next).

@ikedas ikedas added the bug label Jul 9, 2018
@finkyseb
Copy link
Author

Ok I understand the problematic, but in our case, our users loose the capability of rename a list.
All actions done with the graphical interface ended with an internal error.
Do you think, you will be able to fix this bug soon ?

Thanks.

@ikedas
Copy link
Member

ikedas commented Jul 21, 2018

Hi @finkyseb,

Can your team give us any solutions or hints to improve scanning directory?

@ikedas
Copy link
Member

ikedas commented Jul 26, 2018

Hi @finkyseb and all,

Does this patch improve? (Note: this patch was poorly tested. Don't apply it to production system).

@ikedas
Copy link
Member

ikedas commented Jul 27, 2018

The patch was updated.

@ikedas ikedas added this to the 6.2.36 milestone Aug 5, 2018
ikedas added a commit that referenced this issue Aug 12, 2018
Rename a list takes incredible time #368
@ikedas
Copy link
Member

ikedas commented Sep 10, 2018

Hi @finkyseb and all,

My fix will be released with the next stable, 6.2.36. If it will not improve satisfactorily, please re-open this issue.

Thanks for inputs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants