Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error escaping apostrophe on stats page #428

Closed
laerm opened this issue Oct 2, 2018 · 3 comments · Fixed by #430
Closed

Error escaping apostrophe on stats page #428

laerm opened this issue Oct 2, 2018 · 3 comments · Fixed by #430
Labels
Milestone

Comments

@laerm
Copy link

laerm commented Oct 2, 2018

Version

6.2.36 (but I believe it's been present for quite a few versions)

Installation method

sympa-ja.org.rhel.repo

Expected behavior

Stat plots should display

Actual behavior

Stat plots with apostrophes in the title don't display

Additional information

Sympa version is in french. So for example title of plot chartdivdel is "Utilisateur supprimé par l'administrateur". The apostrophe throws a javascript error and the plot is completely blank. Same for plot
chartdivadd_or_subscribe, the French title is "Ajout d'abonnements".

ikedas added a commit to ikedas/sympa that referenced this issue Oct 3, 2018
@ikedas
Copy link
Member

ikedas commented Oct 3, 2018

Hi @laerm,

Can you please apply this patch to stats.tt2 and check if the problem will be solved? Thanks.

@ikedas ikedas added the bug label Oct 3, 2018
@ikedas ikedas added this to the 6.2.38 milestone Oct 3, 2018
@laerm
Copy link
Author

laerm commented Oct 3, 2018

Hi @ikedas

I can confirm that this patch fixes the issue. Thank you Soji and thank you for your tireless work on this project, it is much appreciated.

Cheers!

@ikedas
Copy link
Member

ikedas commented Oct 4, 2018

@laerm, thanks for reporting and confirming! I found more similar bugs in the other places and fixed them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants