Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit message header/footer template links lost in 6.2.42? #622

Closed
dpc22 opened this issue May 23, 2019 · 0 comments · Fixed by #628
Closed

Edit message header/footer template links lost in 6.2.42? #622

dpc22 opened this issue May 23, 2019 · 0 comments · Fixed by #628
Assignees
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@dpc22
Copy link
Contributor

dpc22 commented May 23, 2019

Version

6.2.42

Installation method

rpms from http://sympa-ja.org/download/rhel/ installed on RHEL 7.

Also installed from source on my Ubuntu workstation to confirm the issue.

Expected behavior

https://my-site/sympa/editfile/listname/message_templates should include:

Added in distributed messages
Edit Message footer: If this file is not empty, it is added as a MIME attachment at the end of each message distributed to the list.
Edit Message header: If this file is not empty, it is added as a MIME attachment at the beginning of each message distributed to the list.

Actual behavior

This text and links are missing.

Additional information

This would seem to be related to NEWS.md:

  • Files for message footer and header were renamed to message_footer and message_header #507.

/usr/share/sympa/default/web_tt2/editfile.tt2 contains, for example:

[% item1 = 'message.footer'
item2 = 'message.header' %]

If I replace the default template with one where:

all instances of "message.footer' are replaced with "message_footer"
all instances of "message.header" are replaced with "message_header"

then things work as I expect.

At the same time I would have expected lots of other people to be asking about this, and I can't see anything on the issue tracker or the sympa-users mailing list. I'm willing to believe that I'm just missing something really obvious as a Sympa novice.

@ikedas ikedas added the bug label May 23, 2019
@ikedas ikedas added this to the 6.2.44 milestone May 23, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 24, 2019
Fix sympa-community#622
Thx to dpc22 who created the issue AND gave the solution
@ldidry ldidry self-assigned this May 24, 2019
ldidry added a commit to ldidry/sympa that referenced this issue May 24, 2019
Fix sympa-community#622
Thx to dpc22 who created the issue AND gave the solution
@ldidry ldidry added the ready A PR is waiting to be merged. Close to be solved label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants