Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot verification for --make_alias_file command line option #746

Closed
racke opened this issue Sep 10, 2019 · 4 comments
Closed

Robot verification for --make_alias_file command line option #746

racke opened this issue Sep 10, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@racke
Copy link
Contributor

racke commented Sep 10, 2019

sympa@local-sympa:~$ /usr/local/sympa/bin/sympa.pl --make_alias_file --robot nevairbe.example.com
Sympa aliases file /var/spool/sympa/tmp/sympa_aliases.1519 was made.  You probably need to install it in your SMTP engine.
sympa@local-sympa:~$ cat /var/spool/sympa/tmp/sympa_aliases.1519 
#
#	Aliases for all Sympa lists open on nevairbe.example.com
#

Sympa produces alias file for bogus robot and doesn't give any error message back to the user.

@racke racke self-assigned this Sep 10, 2019
@racke racke added the bug label Sep 10, 2019
@racke
Copy link
Contributor Author

racke commented Sep 11, 2019

@ikedas How can I check whether $robot contains a valid robot?

@ikedas
Copy link
Member

ikedas commented Sep 11, 2019

I can't get it. Have you created configuration of a new robot? How did you set up list_aliases.tt2 (this can be prepared by each robot)? What does the aliases file contain?

@racke
Copy link
Contributor Author

racke commented Sep 11, 2019

nevairbe.example.com is a fake robot and in my setup I have an alias file for each robot. The point is that the value from --robot is not validated and Sympa generates an empty file.

Therefore I would like to check whether the value is $robot actually is a robot. Please let me know which code can be used for that so I can provide a pull request for this problem.

@ikedas
Copy link
Member

ikedas commented Sep 11, 2019

Oh I see.
Currently we may use Conf::valid_robot() to check if a domain is vaild mail domain.

@ikedas ikedas added this to the 6.2.46 milestone Sep 15, 2019
@ikedas ikedas added ready A PR is waiting to be merged. Close to be solved and removed ready A PR is waiting to be merged. Close to be solved labels Sep 15, 2019
@ikedas ikedas closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants