-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show subjects of archived mails before deletion’s confirmation #1025
Show subjects of archived mails before deletion’s confirmation #1025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<input type="checkbox" name="msgid" value="$MSGID$_SYMPA_$SUBJECTNA$" />
This will make HTML archives not backward-compatible. (And, this is a matter of personal taste, but separator _SYMPA_
looks a bit inelegant for me).
Instead of doing as above, for example, we may use jQuery to enable/disable msg_subject
, doing such as:
($tag$% msgidx = msgidx || 0; msgidx = msgidx + 1 ~%$tag$)
<input type="checkbox" name="msgid" value="$MSGID$"
id="msgid($tag$% msgidx %$tag$)" />
<input type="hidden" name="msg_subject" value="$SUBJECTNA$"
class="disableUnlessChecked"
data-selector="#msgid($tag$% msgidx %$tag$)" />
About disableUnlessChecked
class see www/js/sympa.js
.
I thought about using javascript but I wanted to have a solution for those who don’t use JS. Indeed, it’s not backward compatible but we can have a message in the CHANGELOG saying that admins can rebuild archives… or not, since it doesn’t break anything for old archives, it just have the old behavior 🙂 I’ll recode it to use JS |
005f8d0
to
beb4b34
Compare
Here we go: new method, with JS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found no problem. Thanks for improvement!
🍻 |
Since 6.2.58 has been released, shouldn’t it be merged? |
I think it would be good to have a reminder of which archived mails are about to be deleted (just like the reminder of the subscribers who are about to be unsubscribed), so here it is.