Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listname typo #121

Closed
wants to merge 1 commit into from
Closed

Fix listname typo #121

wants to merge 1 commit into from

Conversation

jean1
Copy link
Contributor

@jean1 jean1 commented Nov 11, 2017

list name was not rendered as a dot was missing
(listname instead of list.name)

@jean1
Fix listname typo
3ff5552 
list name was not rendered as a dot was missing
(listname instead of list.name)
@ikedas ikedas added the bug label Nov 13, 2017
@ikedas ikedas added this to the 6.2.24 milestone Nov 13, 2017
@ikedas
Copy link
Member

ikedas commented Nov 15, 2017

In the case type == 'hundred_percent_error', list.name is defined, but in the case type == 'automatic_list_creation_failed', it is not defined. In latter case listname looks correct.

@ikedas ikedas mentioned this pull request Nov 25, 2017
Merged
ikedas added a commit that referenced this pull request Nov 25, 2017
@ikedas
Merge pull request #128 from ikedas/pr-121bis
7df43ed 
Fix listname typo #121, revised by jean1 and ikedas
@ikedas
Copy link
Member

ikedas commented Nov 25, 2017

I merged your PR partly (a part of your changes are reverted).
This PR will be closed. Thank you for reporting & fixing bug!

@ikedas ikedas closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.24
Development

Successfully merging this pull request may close these issues.
2 participants
@jean1 @ikedas