Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in implementation and documentation of typical list profile (create list templates) #157

Merged
merged 4 commits into from
Jan 17, 2018

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jan 8, 2018

  • [bug] Feature of create_list is not the same as what described in documentation:

    • description (info) parameter is not mandatory.
    • the "moderator" parameter in documentation has never been implemented: "editor" would be used.
    • moreover, "moderator" was treated either as multiple values or single value in a few parts of documentation.
    • "topic" was implemented as documentation describes, not "topics", but some of code uses "topics".

    Fixed, with implementing "moderator" attribute in XML file as synonym of "editor", allowing both single and multipe values.

    NOTE: Inconsistencies in documentation were fixed on the new documentation site: 1, 2.

  • [bug] Files config.tt2 in default templates did not support gecos of editors.

ikedas added 3 commits January 8, 2018 18:41
…tation:

  - description (info) parameter is not mandatory.
  - the "moderator" parameter in documentation has never been implemented: "editor" would be used.
  - "topic" was implemented as documentation describes, not "topics", but some of code uses "topics".

Fixed, with implementing "moderator" as synonym of "editor", but without multipe attribute.
@ikedas ikedas added the bug label Jan 8, 2018
@ikedas ikedas added this to the 6.2.26 milestone Jan 8, 2018
ikedas added a commit to sympa-community/sympa-community.github.io that referenced this pull request Jan 8, 2018
ikedas added a commit to sympa-community/sympa-community.github.io that referenced this pull request Jan 9, 2018
Another fixup about sympa-community/sympa#157: Use editor instead of moderator in the XML file for family.
@ikedas ikedas changed the title Inconsistencies in implementation of typical list profile (create list templates) Inconsistencies in implementation and documentation of typical list profile (create list templates) Jan 9, 2018
ikedas added a commit to ikedas/sympa-community.github.io that referenced this pull request Jan 10, 2018
ikedas added a commit to ikedas/sympa-community.github.io that referenced this pull request Jan 10, 2018
Another fixup about sympa-community/sympa#157: Use editor instead of moderator in the XML file for family.
@ikedas ikedas merged commit 4a586c7 into sympa-community:sympa-6.2 Jan 17, 2018
@ikedas ikedas deleted the pr-109-fixup branch January 17, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant