Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WWSympa: Improving subscribe, signoff and auth functions #26

Merged
merged 9 commits into from
Jul 15, 2017
Merged

WWSympa: Improving subscribe, signoff and auth functions #26

merged 9 commits into from
Jul 15, 2017

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jul 8, 2017 •
edited
Loading

Functions subscribe, signoff and auto_signoff on web interface were rewritten so that:

  • The bug spamming authorization requests was fixed. Now clicking subscribe/unsubscribe links will not start the function immediately but will start confirmation steps.
  • Potentially risky one-time tickets will no longer be used for these functions.
  • Now AUTH function is available on web interface along with mail interface.
  • Functions above were integrated to Sympa::Request framework, also on SOAP server.

As side works, a few unused functions and several redundant messages were removed.

ikedas added 5 commits July 5, 2017 13:02
@ikedas
Refactoring: Integrating 'subscribe' function on web interface to Sym…
6782868 
…pa::Request framework.

One-time ticket will no longer be used, and possible information leakage was fixed.
@ikedas
removing unused variables.
dc693b3
@ikedas
Refactoring: Integrating 'signoff' function on web interface to Sympa…
70e8323 
…::Request framework.

One-time ticket will no longer be used, and possible information leakage was fixed.
@ikedas
[feature] WWSympa: New "auth" action to confirm actions.
6aa8a6a 
- request_auth.tt2 will show web link instead of mailto link by default.
- potentially risky one-time ticket will no longer used to authorize subscription and unsubscription.
@ikedas
WWSympa: auto_signoff was rewritten; multiple?subscribe & multiple_si…
21d2f9d 
…gnoff were removed because they have never been used.

Removing some unused stuff.
@ikedas ikedas merged commit b9f2380 into sympa-community:sympa-6.2 Jul 15, 2017
@ikedas ikedas deleted the spamming_subscribe branch July 15, 2017 04:06
@ikedas ikedas mentioned this pull request Jul 18, 2017
Closed
@ikedas ikedas added this to the 6.2.20 milestone Jul 25, 2017
@ikedas ikedas mentioned this pull request Oct 6, 2017
Merged
@ikedas ikedas mentioned this pull request Oct 29, 2017
Merged
@ikedas ikedas mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
6.2.20
Development

Successfully merging this pull request may close these issues.
1 participant
@ikedas