Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11: Spurious error on duplicate keys with admin sync, and changes on configuration for owners/moderators #275

Merged
merged 14 commits into from
Apr 30, 2018

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Apr 22, 2018

This PR depends on PR #267.


Bug fix:

Changes/improvements:

  • Form to edit owners and moderators are removed from list config page: They have their own menus.
    2018-04-22 19 00 04
  • When a list is created, initial owners and moderators are importd from dump file in list directory: owner and editor parameters in config file are no longer loaded.
    • However, when list is created using list creation template, owner and editor are split into dump files automatically: users need not update config.tt2.
    • And however, when administrator manually creates a list by creating list directory and config file, they also have to put dump files and have to run sympa.pl --restore_users.

Known bugs:

  • Big data source consumes large memory, because entire records are read at once when users are synchronized. Fixed
  • Owner/editor edition pages do not respect privileges defined by edit_list.conf. This will be fixed later. Fixed

ikedas added 14 commits April 14, 2018 18:28
They dump or restore list users (members, owners or editors) in database from/to file.

[change] File for members was changed to `<list dir>/member.dump` which will replace:
  - `subscribers` (used by Sympa prior to 5.4a.1)
  - `subscribers.db.dump` (generated by dump command)
  - `subscribers.closed.dump` (backup for closed list)
[change] Additional files to dump owner or editor: `<list dir>/owner.dump`, `<list dir>/editor.dump`.
They will be used as initial (permanent) owners/editors, or as backup for closed list
[*change] owner and editor parameters in list config file are no longer sync with actual owners/editors.  They are used only at the time of installation of list.
…gistered as permanent (not included) members. Also, subscription suspension option are cleared and so on.

Fxied by dump and restore all information of subscribers in database.
  - `--dump` dumps list members/owners/editors to file under list directory.
  - `--suck` restores list members/owners/editor from this file.
…), respectively.

Options for sympa.pl are also renamed to --dump_users and --restore_users.
… admin sync

  - Now sync_include_admin() passes cache and updates admin_table directly.
  - It no longer reload owner/editor in list config.

Known bug: Big datasource consumes large memory.
[-feature] "owner" and "editor" in list profile (create list template) are written in dump files when a list is created.

ToDo: edit.tt2 should refer to edit_list.conf.
@ikedas ikedas merged commit 1d6b19e into sympa-community:sympa-6.2 Apr 30, 2018
@ikedas ikedas deleted the issue-11_trial4 branch May 5, 2018 07:47
This was referenced May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant