Tidy up all files

[ldidry]

The interest in having perltidy tests in Travis is to check for non-tidy code introduction, but it can only be achieved if Sympa itself passes the test. This PR makes Sympa passes the test successfully.

Use git diff --ignore-all-space on the commit to show only non-spaces changes (there is a lot of space changes)

[ikedas]

Weird indentation (I tried perltidy-ing again, but this was not fixed). Bug (or feature) of Perl::Tidy?

[ldidry]

Well, IMHO, that's not the weirdest indentation that Perl::Tidy asked for. I'm not a big fan of src/lib/Sympa/Database.pm L.77 for ex.

Also, I can't find it anymore (too much changed files), but I remember there's an if that have its closing ) { not on the same level of indentation and that was weird since Perl::Tidy made me change a lot of closing ) { indentation.

[ikedas]

I see. How weird perltidy does, it does its best.

[ikedas]

I checked with Perl 5.26.0 + Perl::Tidy-20180220, and all on modules were OK.

• Executables would also be better to be tidied.

I executed as below:

$ perltidy -pro=doc/dot.perltidyrc -it=2 -b \
cpanfile \
src/*/*.{pl,fcgi}.in \
`find src -name '*.pm'` \
src/lib/Sympa/Constants.pm.in

[ldidry]

Just a thought: we could avoid quite a lot of carriage return just by using a max line width of 80 cols. It may improve readability. Should we use that value?

[ikedas]

I forgot exact reason, but there might be a consideration for general terminals. On 80-cols display, newline of a line with 80-cols might run over into the next line.

[ldidry]

Ok.