Use rsa-sha256 for DKIM signatures #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sympa currently uses rsa-sha1 for DKIM signature attached to outgoing mails. It [has been shown](https://shattered.io/) that SHA-1 can no longer be considered resistant to collisions in practice, which means that it is inadequate to be used with DKIM. Since Mail::DKIM supports rsa-sha256, this is easy to fix.
|
Makes sense to me 👍 Do you know since which version Mail::DKIM supports rsa-sha256? |
|
Since version 0.17 from 2006, so this should not pose any restrictions. |
|
Indeed 😇 , thanks for the report! |
|
While this is not a security issue in sympa code by itself, wouldn't that still make sense this PR be tagged "security" too ? |
|
I agree with this assessment. As sha1 has been broken in practice, this is not just a theoretical issue.
|
|
@xavierba ++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sympa currently uses rsa-sha1 for DKIM signature attached to outgoing mails. It has been shown that SHA-1 can no longer be considered resistant to collisions in practice, which means that it is inadequate to be used with DKIM. Since Mail::DKIM supports rsa-sha256, this is easy to fix.