Make "http_host" parameter optional

[ikedas]

In most cases, http_host parameter is duplicate of wwsympa_url (As of 6.2.15, they may be differ only in case that WWSympa is placed behind reverse proxy). That is why this parameter would be optional: If http_host is not specified, value of wwsympa_url would be used.

---

ToDo: Now its name http_host is inappropriate: It would be better to have new name such as wwsympa_url_local, however, anyone will do it in the future.

---

Update: Also added new parameter soap_url_local corresponding to soap_url.

[racke]

Also it would be more useful to examine the X_FORWARDED_HOST environment variable if we are behind a reverse proxy instead of use a static value from configuration.

[ikedas]

Also it would be more useful to examine the X_FORWARDED_HOST environment variable if we are behind a reverse proxy instead of use a static value from configuration.

It was disabled at b3348f7 (see get_server_name() and get_http_host() in Sympa::Tools::WWW). My idea at that time was that HTTP_X_HORWARDED_* is not trustworthy (it has no official format and could be forged by client side easily), and should not always be enabled.

If someone feel it useful, option like override_server_name_by_environment_variable might be added.

[racke]

On 08/06/2017 12:33 PM, IKEDA Soji wrote: Also it would be more useful to examine the |X_FORWARDED_HOST| environment variable if we are behind a reverse proxy instead of use a static value from configuration. It was disabled at b3348f7 <b3348f7> (see get_server_name() and get_http_host() in Sympa::Tools::WWW). My idea at that time was that |HTTP_X_HORWARDED_*| is not trustworthy (it has no official format and could be forged by client side easily), and should not always be enabled.

Yeah, of course it shouldn't be always enabled. A configuration directive would be good though - if you know that you are always behind a reverse proxy :-). If you agree, I would open a new issue. Regards Racke

…

If someone feel it useful, option like |override_server_name_by_environment_variable| might be added. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIxPm-QgHXK4gxZ2-pFnWvn-_o_h0wKks5sVZZdgaJpZM4Ose20>.

-- Ecommerce and Linux consulting + Perl and web application programming. Debian and Sympa administration.

[ikedas]

If you agree, I would open a new issue.

I agree.

(I guess this theme (service behind proxy) is worth spending one chapter in documentation.)