Implementing expire_members task #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le instead of removing it.
"expire" task has never been implemented and parameter was kept ineffective. To avoid unintentional execution of task with old setting, new parameter for "expire_members" should not be an alias of old one.
|
Has expire_task never been implemented in 6.2.37b1?? It's allow set in Admin page of sympa. |
|
I think that is the original problem which is supposed to be solved with this PR @acasadoual |
|
I'd like to withdraw this PR. Because this won't work as expected, if |
|
I submitted new issue #475. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: "expire" task has never been implemented and expire_task parameter was kept but ineffective. To avoid unintentional execution of task with old setting, new parameter for "expire_members" should not be an alias of old one.
This PR depends on PR #394.