Fix shared docs zip upload to send multiple files at once #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian 9, with perl 5.24.1 and Archive::Zip 1.59 and 1.64, uploading
a zip file to let Sympa (6.2.34) unzip it and put its files into shared
docs fails.
The zip member is a CGI::File::Temp instance and can seek but fails to
be extracted ("Unable to extract member XXX of the zip file" in Sympa
logs).
Unconditionnally blessing the file handle to IO::File fixes the failure.
|
@ldidry, for my interest, what is the version of CGI module? |
|
It's Debian's one: |
|
I merged your commit with my commit to note unusual bless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian 9, with perl 5.24.1 and Archive::Zip 1.59 and 1.64, uploading
a zip file to let Sympa (6.2.34) unzip it and put its files into shared
docs fails.
The zip member is a CGI::File::Temp instance and can seek but fails to
be extracted ("Unable to extract member XXX of the zip file" in Sympa
logs).
Unconditionnally blessing the file handle to IO::File fixes the failure.