Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCGI scripts will not always restart when they are updated #58

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Sep 16, 2017

FCGI scripts (wwsympa.fcgi and sympa_soap_server.fcgi) will not always restart when they are updated.

  • exit(0) occurred only when script file is updated: This assumption is not always true. It would be better to occur whenever timestamp is simply changed.
  • The time of startup was used for origin of change. Timestamp of script would be used instead.
  • Non-standard SCRIPT_FILENAME CGI environment variable was referred. Instead use $PROGRAM_NAME ($0).

Note:

  • Separate FastCGI server like spawn-fcgi needs restart. With systemd, Restart directive may be useful. With traditional sysVinit script, manual restart may be required.

- exit(0) was caused only when script file is updated: On binary distributions this assumption is not true. If would be caused anytime when timestamp is simply changed.
- The time of startup was used for origin of change. Timestamp of script would be used instead.
- Non-standard `SCRIPT_FILENAME` environment variable was referred. Instead use `$PROGRAM_NAMe` (`$0`).
@ikedas ikedas added the bug label Sep 16, 2017
@ikedas ikedas added this to the 6.2.20 milestone Sep 16, 2017
@ikedas ikedas merged commit b84bdfb into sympa-community:sympa-6.2 Sep 22, 2017
@ikedas ikedas deleted the reload_fcgi branch September 22, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant