Slight change in list admins cache expiry. #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dmins cache is not updated. Consequently, when trying to add a third admin in the same second, the second one is not in the cache at the time. Obviously it does not sound like a recurrent scenario and I met this problem when running a test file only. However, it is possible that this happens more often when trying to make batch modifications in the shell. And also, it made my test fail which is an engineering problem: it could be misguiding about the cause of a test failure. So I changed the expiration test, replacing "<" by "<=" and it solves the problem. I don't see any side problem that could result from this change bu I commit it separately anyway because the cache is very sensitive.
|
I feel it's good. |
|
Oh really? I thought it was introduced to fix performances problems. |
|
The cache caused tons of problems. |
|
Indeed but I thought it was fixed by now. But then again, I may have missed some conversations. |
|
We used up a whole package of band aids, but the patient haven't recovered yet 🙄. Caching incorrectly causes more harm than it helps, especially home grown solutions like we got introduced into Sympa. |
|
That should be a dedicated issue. |
Open
salaun-urennes1
pushed a commit
to salaun-urennes1/sympa
that referenced
this pull request
May 12, 2020
…prevented the cache from being used by _cache_get(). PR sympa-community#583 introduced a bug: most of the time equals ; _cache_get() returned undef whereas the data was in cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing a list's admin two times in the same second, the list admins cache is not updated. Consequently, when trying to add a third admin in the same second, the second one is not in the cache at the time.
Obviously it does not sound like a recurrent scenario and I met this problem when running a test file only.
However, it is possible that this happens more often when trying to make batch modifications in the shell. And also, it made my test fail which is an engineering problem: it could be misguiding about the cause of a test failure.
So I changed the expiration test, replacing "<" by "<=" and it solves the problem.
I don't see any side problem that could result from this change bu I commit it separately anyway because the cache is very sensitive.