dkim_sign: Normalize CRLF->LF for DKIM-Signature #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mail::DKIM::Signer
wrapsDKIM-Signature
with with\r\n\t
; this is the hardcodedSeparator
passed toMail::DKIM::TextWrap
viaMail::DKIM::KeyValueList
.MIME::Tools
on the other hand(
MIME::Head::stringify()
in particular) encode EOL as plain\n
; it is thus necessary to normalize CRLF->LF forDKIM-Signature
to avoid confusing the mail agent.Exim in particular handles line endings by observing these rules of interest:
The result can be seen in the following example, where:
DKIM-Signature
are indented by one space and are practically lostMessage-Id
andFrom
(using gecos field for sympa system user)