PR#582 addition 1 #592
Merged
PR#582 addition 1 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 4 spaces indentation
- Indent on HTML tags AND on TT2 stuff ([% IF … %])
- Avoid HTML or TT2 oneliners like:
```
[% IF top_menu %]…[% END %]
<div class="displayNone"><a href="#top">Top of Page</a></div>
```
- When a tag has too many attributes to be on one line, indent the
attributes at the same level than the first one:
```
<label class="foo"
id="bar">
Baz
</label>
```
Merged
|
Very good Soji. We got these kind of HTML tags in the catalogues for too long. |
|
Could you have a look at |
|
It's at the beginning of the file, line 8, you can’t miss it. |
…ts in translated strings. Note: Message catalog should be tweaked.
…ments in translated strings. Note: Message catalog should be tweaked.
ikedas
force-pushed
the
pr-582-addition_1
branch
from
2463a55 to
ab44d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix to PR #582 (1) sso_login.tt2: Don't include HTML elements in translated strings.
Note: Message catalog should be tweaked.