Fix #621 — Add a 'gecos' option to web_archive_spam_protection #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otection This allows to make web archives public without fearing to leak users email addresses.
ikedas
reviewed
May 27, 2019
…n according to @ikedas comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to make web archives public without fearing to leak users
email addresses. This has only effect when you display a mail. In the archive list, the behavior is the current one: display gecos if any, display first part of email address otherwise (i.e.
fooif the address isfoo@bar.org).Please note that I adapted the code from
decorate_email_atsubroutine.Also, I used 'No gecos' as message when the email address didn’t contain a gecos, but feel free to propose somethin more easier to understand.
May fix #621