Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLize: Use filesystem-independent escaping for names of files stored #891

Merged
merged 1 commit into from
Mar 4, 2020
Merged

URLize: Use filesystem-independent escaping for names of files stored #891

merged 1 commit into from
Mar 4, 2020

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Feb 26, 2020

An insignificant bug.

Discouraged Sympa::Tools::Text::escape_chars() was used in the name of file stored for URLize mode.

@ikedas ikedas added the bug label Feb 26, 2020
@ikedas ikedas added this to the 6.2.56 milestone Feb 26, 2020
@ikedas ikedas requested a review from dverdin February 26, 2020 07:16
dverdin
dverdin approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@dverdin dverdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a seamless change and all the tests stll validate, so I'm pretty confident with this change.
If you feel the code is better this way, no problem!

@ikedas
Copy link
Member Author

ikedas commented Mar 4, 2020

@dverdin , thanks for your review!

@ikedas ikedas merged commit ba429c6 into sympa-community:sympa-6.2 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dverdin dverdin dverdin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.56
Development

Successfully merging this pull request may close these issues.
2 participants
@ikedas @dverdin