Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.2] New code for list config semantics #9

Merged
merged 24 commits into from
Apr 23, 2017
Merged

[6.2] New code for list config semantics #9

merged 24 commits into from
Apr 23, 2017

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Apr 18, 2017

Rewriting code for list config semantics.

  • New class Sympa::List::Config which may replace aged code.
  • wwsympa/edit_list was rewritten along with following bug fixes:
    • Possible crash due to malformed input.
    • Can't remove the value of optional scalar parameter (e.g. custom_subject).
    • LIST-editor address of the list itself can be set as value of editor.email.
    • and several other insignificant bugs.
  • Now configuration definition allows recursion with any depth.
  • Processing of family constraint became simpler.

Config file parser would be also rewritten using this new class.

ikedas added 15 commits April 15, 2017 07:25
@ikedas
[bug] WWSympa: edit_list: Possible crash due to malformed input.
c8ec978 
POST parameter names are decoded into internal structure, e.g. "multiple.owner.0.gecos" to $new_admin->{'owner'}[0]{'gecos'}.  Inconsistent names may cause fatal error, e.g. by "multiple.owner.0.gecos.foo".  Fixed by passing over such errors.
@ikedas
[-bug] WWSympa: notice.tt2 was broken.
2a9058a
@ikedas
src/lib/Sympa/ListDef.pm
50fa331
@ikedas
[-bug] List config parameter custom_attribute.optional has no default.
27701f3
@ikedas
[-bug] List config parameter custom_attribute.optional has no default.
22f9459
@ikedas
[-bug] Inconsistent definition of topics list parameter.
d52c0be 
It should be the set of topics names but defined as array of scalars.
@ikedas
Introducing Sympa::List::Config to manage list configuration (work in…
84d89d3 
… progress).
@ikedas
[-bug] List topic names cannot be "others" or "topicsless".
fdb42a0 
They in topics.conf would be ignored.
@ikedas
Sympa::List::Config: Introducing submit(), commit(), get(), get_chang…
c0f2281 
…e().

Sympa::ListDef: Attribute 'validations' to validate inputs.
@ikedas
Reimplementing family feature and most of commit().
6a292e9
@ikedas
[-bug] List editor special address can be set as editor email.
c7e0b8b 
Fixed by adding a validation to check if such address was submitted.
@ikedas
Rewriting mostly completed.
4acb8c6
@ikedas
Copyedit. Added constructor options.
2d11e08
@ikedas
More precise family constraint.
8076e56
@ikedas
do_edit_list() has been mostly rewritten using new config framework.
856f9a9
@ikedas ikedas added the bug label Apr 18, 2017
@ikedas ikedas requested review from dverdin and removed request for dverdin April 22, 2017 10:07
ikedas added 2 commits April 23, 2017 10:37
@ikedas
Adding documentation.
497a232
@ikedas
Mostly done changes on this PR.
324bc68 
* Making get(), get_change(), key() be possible to take multi-level parameter names.
* Adding get_schema().
* Avoiding optional parameters to be reset by default value at the time of reloading.
@ikedas ikedas merged commit f44fe80 into sympa-community:sympa-6.2 Apr 23, 2017
@ikedas ikedas deleted the 6.2-edit_list-rewrite branch April 23, 2017 06:52
@ikedas ikedas restored the 6.2-edit_list-rewrite branch April 24, 2017 01:16
@ikedas ikedas added this to the 6.2.17 milestone May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.17
Development

Successfully merging this pull request may close these issues.
1 participant
@ikedas