Improve logging of archive errors due to possible permission problems #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikedas
reviewed
Mar 7, 2020
| $ERRNO; | ||
| $log->syslog('err', 'Cannot open dir %s: %s', $self->{arc_directory}, | ||
| $ERRNO); | ||
| return undef; |
There was a problem hiding this comment.
I think this is the case when "Sympa has no choice but to die" (cf. #90 ). It's fatal that $self->{arc_directory} is set, i.e. select_archive() has succeeded, while it cannot be opened.
There was a problem hiding this comment.
I can see your point ... but it leaves the web interface user with the die output which should not happen other than real corner cases. What about checking whether the directory can be read in the beginning of do_arc?
There was a problem hiding this comment.
Checking readability may not be the solution, I think. But this topic seems beyond the scope of this pr, and I’ll stop commenting for the present.
ikedas
reviewed
Mar 7, 2020
ikedas
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.