Fix CSS attributes for un-hovered navigation menu items using color_5 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our local branding guidelines require a color set that results in fairly dark colors for the top menu items, with a contrasting lighter color for the current item.
We found that when color_5 is set to something other than the default, the current menu item is still rendered as light blue instead of color_5.
Drawing from the code using color_6 immediately above it, this patch to css.tt2 uses color_5 as the background color for the active menu item when it is not being hovered over.
With this update, the colors are as expected and the GUI seems to work correctly when driving under 6.2.22. That is, the current menu item is color_5 (e.g. burnt orange), the rest are color_6 (dark brown), and hovering the mouse over another menu item properly changes the background to color_5 (burnt orange) as well.
--mic--