Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate implicit sync_include in Sympa::List constructor #955

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jun 7, 2020

  • review: Won't process sync_include in advance so that processing will be faster.
    sync_include just before message delivery will be performed as in the past.

  • sync_include will no longer be invoked during Sympa::List->new():

    • No owner defined in a list is no longer treated as error_config.
    • Instead, if no owner defined and something has to be sent to owners,
      • If possible, discard incoming message and send back DSN to original sender,
      • or, notifications to owners will be redirected to listmaster(s).

This may improve speed of "review" page and so on.
Also, this may fix #92 .

ikedas added 5 commits May 28, 2020 17:28
…ead, "include" request handler had "delay" option.
  - No owner defined in a list is no longer treated as error_config.
  - Instead, if no owner defined,
     - If possible, discard incoming message and send back DSN to original sender,
     - or, notifications to owners will be redirected to listmaster(s).
@ikedas
Copy link
Member Author

ikedas commented Jun 7, 2020

@salaun-urennes1 , could you please check if this change is useful?

@ikedas ikedas added this to the 6.2.58 milestone Jul 10, 2020
@ikedas ikedas merged commit 6aa1a06 into sympa-community:sympa-6.2 Jul 10, 2020
@ikedas ikedas deleted the delayed_sync_include-trial2 branch July 10, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Re)allow lists to only have owners from data sources
1 participant