Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add scenari to restrict message submission to list owners #96

Merged
merged 2 commits into from
Oct 21, 2017

Conversation

mpkut
Copy link
Contributor

@mpkut mpkut commented Oct 13, 2017

As part of a long-ago migration from Listproc to Sympa, our site created a send scenario to restrict submission to list owners only. It has proven to be a clear, self-documenting way to implement announcement-only lists that do not require moderation.

This patch adds scenari named "send.owners" and "send.ownerkey" to implement this feature, and updates report.tt2 to say "you must be a list owner to send to this list" when the scenario rejects the submission.

--mic--

@ikedas ikedas added this to the 6.2.24 milestone Oct 14, 2017
@ikedas
Copy link
Member

ikedas commented Oct 14, 2017

Thanks for useful contribution!

The name send.owners would be better to be send.owner for consistent naming.

And I feel send.ownerkey is a bit exceptional naming. IMHO send.ownerauth seems better.

@mpkut
Copy link
Contributor Author

mpkut commented Oct 16, 2017

Thank you for reviewing this submission! I am up for whatever naming seems best. Should I close this pull request and submit another with "send.owners" and "send.ownerauth" as you specify?

@ikedas
Copy link
Member

ikedas commented Oct 17, 2017

@mkput, you need not submit new pull request. You can do the changes (git mv send.owners send.owner and so) on feature_send_by_owners branch in your fork, commit them and push. By doing such, changes will be added to this PR.

@mpkut
Copy link
Contributor Author

mpkut commented Oct 17, 2017

OK, thank you - done!

@ikedas ikedas merged commit bf89450 into sympa-community:sympa-6.2 Oct 21, 2017
@mpkut mpkut deleted the feature_send_by_owners branch October 23, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants