Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fr.po #979

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Update fr.po #979

merged 2 commits into from
Aug 11, 2020

Conversation

bikepunk
Copy link
Contributor

@bikepunk bikepunk commented Aug 7, 2020

fix a wrong translation

bikepunk added 2 commits August 7, 2020 15:13
@bikepunk
Update fr.po
691d5dc 
fix a wrong translation
@bikepunk
Update fr.po
fe1063f 
there were actually 2 occurences of the mistake
@bikepunk
Copy link
Contributor Author

bikepunk commented Aug 7, 2020

the first commit has trouble with line endings, because of using the github web editor :
"We’ve detected the file has mixed line endings. When you commit changes we will normalize them to Windows-style (CRLF)."

I don't know the workaround with CLI :-|

@ikedas ikedas merged commit d85aa0f into sympa-community:sympa-6.2 Aug 11, 2020
@ikedas ikedas added the bug label Aug 11, 2020
@ikedas
Copy link
Member

ikedas commented Aug 11, 2020

Thanks for fixes!

@ikedas ikedas added this to the 6.2.58 milestone Aug 11, 2020
@bikepunk
Copy link
Contributor Author

just hoping the Windows-style (CRLF) line endings won't break anything.

@ikedas
Copy link
Member

ikedas commented Aug 17, 2020

just hoping the Windows-style (CRLF) line endings won't break anything.

I couldn't find any evidence that gettext allows CRLF as line endings, but it's likely. Do you know of any sources that explicitly state that?

@bikepunk
Copy link
Contributor Author

just hoping the Windows-style (CRLF) line endings won't break anything.

I couldn't find any evidence that gettext allows CRLF as line endings, but it's likely. Do you know of any sources that explicitly state that?

no sources (I'm not dev BTW). just (most probably) unnecessary worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.58
Development

Successfully merging this pull request may close these issues.
2 participants
@bikepunk @ikedas