Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sympa.pl: Add an option "--rebuildarc=list@domain" to rebuild archives #994

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Sep 8, 2020

Relative to #993: with this option, we can rebuild all archives with a simple for bash loop, without restarting from beginning if archived.pl restarts while rebuilding all lists.

Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyword rebuild_arc has never been used. I feel rebuildarc looks less confusing.

@ldidry
Copy link
Contributor Author

ldidry commented Sep 8, 2020

I have no pb with that. I choosed rebuild_arc since it’s closer to natural language.

@racke
Copy link
Contributor

racke commented Sep 8, 2020

Natural language would be rebuild_archives. An arc is part of a building.

@ldidry
Copy link
Contributor Author

ldidry commented Sep 8, 2020

I said "closer", not "exactly" 😅

Relative to sympa-community#993: with this option, we can rebuild all archives with a
simple `for` bash loop, without restarting from beginning if
`archived.pl` restarts while rebuilding all lists.
@ldidry ldidry force-pushed the sympa.pl-rebuild_arc branch from 62b61a2 to 9aa292b Compare September 9, 2020 09:04
@ldidry ldidry changed the title sympa.pl: Add an option "--rebuild_arc=list@domain" to rebuild archives sympa.pl: Add an option "--rebuildarc=list@domain" to rebuild archives Sep 9, 2020
@ldidry
Copy link
Contributor Author

ldidry commented Sep 9, 2020

Now, it’s rebuildarc.

Copy link
Contributor

@dverdin dverdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a quick and useful utility. I see absolutely nor problem with it.
Actually, I wonder whether the "rebuild all" command should be declined in a similar way : a set of single "rebuild list" tasks for each list.

(in the doc, I would say "rebuild the list's archives" but then again it's perfectly understandable this way)

@ldidry
Copy link
Contributor Author

ldidry commented Sep 9, 2020

Actually, I wonder whether the "rebuild all" command should be declined in a similar way : a set of single "rebuild list" tasks for each list.

It may be more simple than track the state of "rebuild all lists" task.

While it’s doable, it could take a lot of time to create all the "rebuild list" messages if there is many lists, so it would make a timeout on the web interface. I suggest, if this is a thing we want to do, to create a "schedule rebuild all list" message that would create all the "rebuild list" messages when processed.

What do you think?

@dverdin
Copy link
Contributor

dverdin commented Sep 9, 2020

Yes, that's certainly the best approach.
This way, the request is instantaneous.
However, it's way out of the current PR's scope. It's perfect this way.

Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no problem.

@ikedas ikedas merged commit 7fc24b6 into sympa-community:sympa-6.2 Sep 22, 2020
@ikedas
Copy link
Member

ikedas commented Sep 22, 2020

Merged for now. Please check the next beta in tomorrow.

@ikedas ikedas added this to the 6.2.58 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants