-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sympa.pl: Add an option "--rebuildarc=list@domain" to rebuild archives #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keyword rebuild_arc
has never been used. I feel rebuildarc
looks less confusing.
I have no pb with that. I choosed |
Natural language would be rebuild_archives. An arc is part of a building. |
I said "closer", not "exactly" 😅 |
Relative to sympa-community#993: with this option, we can rebuild all archives with a simple `for` bash loop, without restarting from beginning if `archived.pl` restarts while rebuilding all lists.
62b61a2
to
9aa292b
Compare
Now, it’s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a quick and useful utility. I see absolutely nor problem with it.
Actually, I wonder whether the "rebuild all" command should be declined in a similar way : a set of single "rebuild list" tasks for each list.
(in the doc, I would say "rebuild the list's archives" but then again it's perfectly understandable this way)
It may be more simple than track the state of "rebuild all lists" task. While it’s doable, it could take a lot of time to create all the "rebuild list" messages if there is many lists, so it would make a timeout on the web interface. I suggest, if this is a thing we want to do, to create a "schedule rebuild all list" message that would create all the "rebuild list" messages when processed. What do you think? |
Yes, that's certainly the best approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found no problem.
Merged for now. Please check the next beta in tomorrow. |
Relative to #993: with this option, we can rebuild all archives with a simple
for
bash loop, without restarting from beginning ifarchived.pl
restarts while rebuilding all lists.