Updated versioneer. Closes #27 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
updateversioneer
branch
8 times, most recently
from
a11e367
to
e0a201f
Compare
oscargus
force-pushed
the
updateversioneer
branch
5 times, most recently
from
be6e707
to
0db5318
Compare
oscargus
force-pushed
the
updateversioneer
branch
from
0db5318
to
2a66b0b
Compare
asmeurer
reviewed
Dec 20, 2021
oscargus
commented
Dec 20, 2021
| @@ -23,6 +25,3 @@ def _test_sphinx_build(app, status, warning): | |||
|
|
|||
| assert not status.read() | |||
| assert not warning.read() | |||
|
|
|||
| def test_sphinx_build(): | |||
There was a problem hiding this comment.
Not sure if this was required or if I am missing something. Seems to work now anyway.
There was a problem hiding this comment.
Probably was required because pytest somehow didn't work with the actual test function (maybe the old test library didn't use a proper pytest fixture?). If it works now without this then we don't need it.
|
Thanks for this. I updated the branch protection rules for the new builds. I'm assuming this doesn't need a release, since it doesn't affect anything until Python 3.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I did the right thing...
Had to drop 2.7-support as the new versioneer doesn't support it.
Also added all (?) 3.x versions for testing.
Ended up replacing sphinx-testing with sphinx.testing, so now the test suite should be fine for 3.11 as well...