Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2023 01 08 #1772

Merged
merged 74 commits into from
Jan 8, 2024
Merged

Release/2023 01 08 #1772

merged 74 commits into from
Jan 8, 2024

Conversation

aureliusbtc
Copy link
Contributor

@aureliusbtc aureliusbtc commented Jan 8, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

40c9c1dcd141589b613df6ef9989babee5fb3817: synapse-interface preview link
97045400807e3001a731f5f18f21810400636784: synapse-interface preview link

abtestingalpha and others added 30 commits November 10, 2023 12:41
…appa as tx from userPendingTransactions before adding to pendingAwaitingCompletionTransaction to display in Activity
ChiTimesChi and others added 4 commits January 8, 2024 11:46
 - @synapsecns/rest-api@1.0.36
 - @synapsecns/sdk-router@0.3.9
 - @synapsecns/synapse-interface@0.1.223
- **New Features**
  - Introduced a new CI/CD workflow with code coverage, snapshot, and size checks.
  - Launched a new RFQ service with a quoting API client.
  - Released new REST API handlers for quote management.
  - Implemented a new inventory management system for the RFQ service.

- **Enhancements**
  - Updated workflows with conditional checks and matrix strategies.
  - Enhanced Docker configurations and image handling in CI/CD pipelines.
  - Improved event parsing and handling in the relayer service.
  - Expanded the database layer with new interfaces and types for quotes.
  - Upgraded command line application setup and execution processes.

- **Documentation**
  - Added a comprehensive README for the RFQ service.

- **Refactor**
  - Refactored event listening and chain indexing logic in the relayer service.
  - Updated method signatures and logic in the relayer's core functions.

- **Bug Fixes**
  - Fixed concurrency issues in the inventory manager's event handling.

- **Style**
  - Standardized comments across several services for consistency.

- **Tests**
  - Added a multitude of new test functions across various RFQ service packages.

- **Chores**
  - Updated import statements and made minor comment changes for clarity.

- **New Contracts and Libraries**
  - Deployed new Solidity contracts for admin and fast bridge functionalities.
  - Provided interfaces for administrative and fast bridge operations.
  - Introduced a universal token library for asset handling.

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>
Co-authored-by: mikeyrf <23126274+mikeyrf@users.noreply.github.com>
Co-authored-by: bsgrigorov <b.s.grigorov@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wasserman <wassermandaniel8@gmail.com>
---------

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented Jan 8, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added M-ci Module: CI M-contracts Module: Contracts go Pull requests that update Go code 2-reviewers M-docker M-synapse-interface size/l labels Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (4655ec1) 51.34246% compared to head (a8b878c) 51.36460%.

Files Patch % Lines
ethergo/backends/base/base.go 12.50000% 21 Missing ⚠️
ethergo/submitter/config/config.go 0.00000% 13 Missing ⚠️
ethergo/backends/base/blacklist.go 28.57143% 5 Missing ⚠️
ethergo/backends/simulated/simulated.go 0.00000% 5 Missing ⚠️
ethergo/backends/geth/geth.go 33.33333% 4 Missing ⚠️
ethergo/backends/anvil/anvil.go 50.00000% 3 Missing ⚠️
ethergo/submitter/submitter.go 83.33333% 2 Missing and 1 partial ⚠️
core/slice.go 0.00000% 2 Missing ⚠️
ethergo/client/client.go 0.00000% 2 Missing ⚠️
ethergo/signer/wallet/wallet.go 0.00000% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##           fe-release       #1772         +/-   ##
====================================================
+ Coverage    51.34246%   51.36460%   +0.02214%     
====================================================
  Files             360         406         +46     
  Lines           24619       27737       +3118     
  Branches          285         295         +10     
====================================================
+ Hits            12640       14247       +1607     
- Misses          10735       12100       +1365     
- Partials         1244        1390        +146     
Flag Coverage Δ
agents 47.44950% <ø> (ø)
cctp-relayer 63.00863% <ø> (?)
core 65.13724% <86.66667%> (+1.03996%) ⬆️
ethergo 60.43550% <31.86813%> (+1.67875%) ⬆️
explorer 24.80881% <ø> (ø)
git-changes-action 53.94265% <ø> (ø)
omnirpc 53.23194% <ø> (+0.03558%) ⬆️
packages 92.93044% <ø> (+1.05294%) ⬆️
promexporter 74.80916% <100.00000%> (?)
release-copier-action 19.33333% <ø> (ø)
rfq 35.91160% <ø> (?)
scribe 52.21130% <ø> (+0.18426%) ⬆️
sinner 64.60481% <ø> (ø)
solidity 93.63708% <ø> (ø)
terraform-provider-helmproxy 16.98113% <ø> (ø)
terraform-provider-iap 18.68687% <ø> (ø)
terraform-provider-kubeproxy 22.83737% <ø> (-0.53033%) ⬇️
tfcore 29.83607% <ø> (+0.38623%) ⬆️
tools 21.98661% <ø> (+0.26209%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trajan0x trajan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aureliusbtc it's 2024

image

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

trajan0x and others added 5 commits January 8, 2024 08:54
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
* update rfq readme

* fix misspell issue

---------

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
@trajan0x trajan0x mentioned this pull request Jan 8, 2024
@trajan0x
Copy link
Contributor

trajan0x commented Jan 8, 2024

Includes the legendary #1650

@trajan0x trajan0x merged commit f80bb29 into fe-release Jan 8, 2024
101 of 102 checks passed
@trajan0x trajan0x deleted the release/2023-01-08 branch January 8, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers go Pull requests that update Go code M-ci Module: CI M-contracts Module: Contracts M-docker M-synapse-interface size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants