[rfq] fix codecov/flake #1795
[rfq] fix codecov/flake #1795
Conversation
WalkthroughThe recent update in the project's configuration involves multiple changes. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Commits
Files that changed from the base of the PR and between e214e94 and 8eb23293270e62e1be9456a3c6f041b7dac2dfc1.Files selected for processing (1)
- ethergo/backends/anvil/anvil.go (1 hunks)
Additional comments: 1
ethergo/backends/anvil/anvil.go (1)
- 82-82: The Docker image tag in
NewAnvilBackendhas been updated to a specific nightly build. Ensure that this tag points to a stable and intended version for the Anvil backend, and that it complies with the project's guidelines for using specific versions versus latest.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
===================================================
- Coverage 52.32849% 50.78737% -1.54112%
===================================================
Files 372 394 +22
Lines 25596 26798 +1202
Branches 285 295 +10
===================================================
+ Hits 13394 13610 +216
- Misses 10898 11857 +959
- Partials 1304 1331 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
trajan0x
force-pushed
the
fix/rfq-codecov
branch
from
8eb2329 to
e214e94
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- services/rfq/e2e/rfq_test.go (1 hunks)
Additional comments: 1
services/rfq/e2e/rfq_test.go (1)
- 140-140: The change in the
DestAmountcalculation frombig.NewInt(1)tobig.NewInt(1000)is quite significant. Could you please provide the rationale behind this change? It's important to ensure that this modification aligns with the intended test behavior and accurately reflects the scenarios you are trying to test.
Description
Fixes rfq codecov & flakes
Tacking CI Flake nere:
FixedFeeMultiplierto rfq fee pricer #1782 and as far back as [rfq] should process is completely ignored #1776 (RFQ #1650 was working)If we query this, we see this is WillNotProcess
Everything else in the nearly 1.7gb of logs generated over an hour are context cancellation errors, so we can narrow the issue down to this 1 line:
And should be able to add breakpoints to find the exact issue:
Since we hit none, we can tell it's isProfitable:
and since cost (500000045) > dest amount out (500000000) this will fail.
For now, we can just subtract a bigger number:
Summary by CodeRabbit
TestUSDCtoUSDCfunction for improved test case behavior.