fix(contracts-communication): deploy proxy script #2392
Conversation
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- packages/contracts-communication/script/deploy/DeployProxy.s.sol (2 hunks)
Additional Context Used
Additional comments not posted (2)
packages/contracts-communication/script/deploy/DeployProxy.s.sol (2)
28-31: The deployment and artifact saving process for theTransparentUpgradeableProxyuses a concatenated naming conventionTransparentUpgradeableProxy.ContractName. This approach aligns with the PR's objective to standardize naming conventions. However, it's important to ensure that this naming convention is consistently applied across all deployment scripts and artifacts within the project to avoid confusion.Consider documenting the naming convention in a central location accessible to all team members, such as a project README or developer guidelines document, to ensure consistency and clarity.
44-45: Saving theProxyAdminartifact with the naming conventionProxyAdmin.ContractNameis a clear and logical approach that enhances the manageability of deployment artifacts. This change effectively addresses the PR's objective of standardizing artifact naming conventions.Ensure that the naming convention for
ProxyAdminartifacts is consistently applied and documented across the project, similar to theTransparentUpgradeableProxyartifacts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
=============================================
Coverage 46.93892% 46.93892%
=============================================
Files 383 383
Lines 29189 29189
Branches 83 83
=============================================
Hits 13701 13701
Misses 14032 14032
Partials 1456 1456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with
|
| Latest commit: |
c2a911e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59f7e5e0.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fix-deploy-proxy-script.sanguine-fe.pages.dev |
* v3 SIN testnet deployment * Chore: rename to comply with #2392 * Chore: `forge fmt` --------- Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>
Description
Adjusted the names for saved deployment artifacts to follow the naming convention:
ContractName.AliasSummary by CodeRabbit