feat(widget): Adds scroll #2805
Conversation
abtestingalpha
requested review from
bigboydiamonds,
aureliusbtc and
trajan0x
as code owners
WalkthroughThe recent updates enhance the Changes
Poem
🐇✨ Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with
|
| Latest commit: |
406b7db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fec771d.sanguine-fe.pages.dev |
| Branch Preview URL: | https://widget-adds-scroll.sanguine-fe.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
NewTagcomponent toSelectSpecificNetworkButton.tsx - Expanded bridgeable assets in
bridgeMap.ts - Added SCROLL chain support in
bridgeable.ts - Included new blockchain network 'Scroll' in
chains.ts
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2805 +/- ##
===================================================
+ Coverage 25.59422% 25.70782% +0.11360%
===================================================
Files 758 700 -58
Lines 54399 51673 -2726
Branches 80 80
===================================================
- Hits 13923 13284 -639
+ Misses 39044 37026 -2018
+ Partials 1432 1363 -69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Improved JSON handling in
BlacklistAddressandGenerateSignatureinclient.go - Removed
datafield fromdb.BlacklistedAddressin Swagger documentation (docs.go,swagger.json,swagger.yaml) - Enhanced
authMiddlewarefor better request body handling inscreener.go - Added
BytesToJSONStringfunction and tests incore/bytes.goandcore/bytes_test.go - Centralized
NewTagcomponent inSelectSpecificNetworkButton.tsx
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- packages/widget/src/constants/bridgeMap.ts (36 hunks)
- packages/widget/src/constants/bridgeable.ts (4 hunks)
- packages/widget/src/constants/chains.ts (2 hunks)
Additional comments not posted (13)
packages/widget/src/constants/chains.ts (2)
285-297: Well-structured addition of the SCROLL blockchainThe addition of the
SCROLLblockchain network is consistent with the structure used for other chains in this file. The properties such asid,name,rpcUrls,explorerUrl,explorerName,blockTime, andimgUrlare all set in a similar fashion to the existing entries, ensuring uniformity and maintainability.
320-320: Ensure the newly added SCROLL chain is properly integrated into the CHAINS objectThe addition of
SCROLLto theCHAINSobject is crucial for its accessibility throughout the application. This change appears correct and should allow theSCROLLchain to be used like any other defined chain. It's important to ensure that all functionalities that interact with theCHAINSobject are updated to handle this new chain correctly.Verification successful
The newly added SCROLL chain is properly integrated into the CHAINS object.
The references to
SCROLLacross multiple files confirm that it is correctly integrated and accessible within the application.
packages/widget/src/constants/chains.tspackages/widget/src/constants/bridgeable.tspackages/synapse-interface/constants/tokens/bridgeable.tspackages/synapse-interface/constants/chains/master.tsxpackages/synapse-interface/constants/chains/index.tsxpackages/sdk-router/src/constants/medianTime.tspackages/sdk-router/src/constants/chainIds.tspackages/synapse-constants/constants/chains/master.tspackages/synapse-constants/constants/chains/index.tspackages/synapse-constants/constants/tokens/bridgeable.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the SCROLL chain is properly integrated and accessible. # Test: Search for SCROLL usage in the codebase. Expect: References to SCROLL in relevant places. rg --type typescript $'SCROLL'Length of output: 64
Script:
#!/bin/bash # Description: Verify that the SCROLL chain is properly integrated and accessible. # Test: Search for SCROLL usage in the codebase. Expect: References to SCROLL in relevant places. rg 'SCROLL' --glob '*.ts' --glob '*.tsx'Length of output: 2045
packages/widget/src/constants/bridgeable.ts (2)
438-438: Added SCROLL blockchain support for USDCThe changes correctly add the SCROLL blockchain support for the USDC token. The address and decimal values are consistent with the USDC specifications on other chains. Ensure that the address
0x06eFdBFf2a14a7c8E15944D1F4A48F9F95F663A4is correct and has been verified.Also applies to: 454-454
804-804: Added SCROLL blockchain support for ETHThe changes correctly add the SCROLL blockchain support for the ETH token. The address is set to
ZeroAddresswhich implies that ETH is native to the SCROLL blockchain, similar to its treatment on other chains like Ethereum and Arbitrum. Ensure that this setting is intended and aligns with the blockchain's characteristics.Also applies to: 815-815
packages/widget/src/constants/bridgeMap.ts (9)
34-42: Correct implementation of new token routes fornUSD.
The addition of new origins and destinations for the tokennUSDcorrectly aligns with the objectives of supporting new blockchain interactions.
71-79: Correct implementation of new token routes forLUSD.
The addition of new origins and destinations for the tokenLUSDis properly formatted and consistent with the PR's objectives.
101-109: Proper extension of token routes forDAI.
The updated origins and destinations forDAIare in line with the expansion plans to new blockchain networks.
124-132: Consistent update forPYUSDorigins and destinations.
The modifications toPYUSDtoken routing are correctly implemented, showing consistency across token configurations.
161-169: Well-implemented routing updates forFRAX.
The changes to theFRAXtoken's origins and destinations align with the intended support for additional blockchain networks.
191-200: Accurate updates forUSDCtoken configurations.
The addition of new routes for theUSDCtoken is correctly implemented, supporting the expansion into new blockchain networks.
235-243: Correct routing additions forWETHandETH.
The updates toWETHandETHtokens include new blockchain interactions which are correctly implemented according to the PR's objectives.
256-264: Appropriate updates forUSDTtoken routes.
The expansion ofUSDTtoken's routing to include new blockchain networks is correctly implemented.
286-294: Well-executed updates forcrvUSD.
The inclusion of new routes for thecrvUSDtoken aligns with the PR's objectives to support additional blockchain networks.
Summary by CodeRabbit
New Features
SCROLLblockchain network, enabling users to interact with this new chain within the app.Enhancements
RFQ.USDCandRFQ.ETH, improving token bridging options.