Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates readme #3268

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Updates readme #3268

merged 1 commit into from
Oct 10, 2024

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Oct 10, 2024

Summary by CodeRabbit

  • Documentation
    • Updated package name in installation instructions to @synapsecns/synapse-constants.
    • Restructured usage section with new instructions for importing supported tokens and chains.
    • Added command for local package building and a new "TODO" section for future enhancements.

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Walkthrough

The changes in this pull request primarily focus on updating the README.md file for the synapse-constants package. Key modifications include a change in the package name for installation instructions, a restructured usage section, the addition of a local build command, and a new "TODO" section outlining future tasks. These updates aim to enhance clarity and streamline the documentation.

Changes

File Change Summary
packages/synapse-constants/README.md - Updated package name from synapse-constants to @synapsecns/synapse-constants in installation instructions.
- Restructured usage section with new import instructions for tokens and chains.
- Added local build command, replacing previous maintenance steps.
- Introduced a "TODO" section for future tasks.

Possibly related PRs

  • Increments package.json version #3211: The changes in this PR involve updating the version number in the package.json file for the synapse-constants package, which is directly related to the main PR that also modifies the README.md for the same package.

Suggested labels

M-synapse-interface, size/s

Suggested reviewers

  • aureliusbtc
  • bigboydiamonds
  • ChiTimesChi

Poem

In the land of code where rabbits play,
Synapse constants have found their way.
With a name so new, and docs so bright,
Building and using, all feels just right!
Hops of joy for tasks ahead,
In the world of tokens, we’ll forge ahead! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
packages/synapse-constants/README.md (2)

15-20: LGTM! Add language specification to the code block.

The addition of build instructions is helpful. However, the fenced code block is missing a language specification.

Apply this change to add the language specification:

-```
+```bash
 yarn build

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 Markdownlint</summary><blockquote>

19-19: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</blockquote></details>

</details>

---

`37-41`: **LGTM! Consider creating GitHub issues for TODO items.**

The addition of a TODO section provides a clear roadmap for future documentation improvements. To ensure better visibility and management of these tasks, consider creating GitHub issues for each item.


Would you like me to create GitHub issues for these TODO items? I can use the GitHub CLI to create the issues with appropriate titles and descriptions.

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: .coderabbit.yaml**
**Review profile: CHILL**

<details>
<summary>📥 Commits</summary>

Files that changed from the base of the PR and between 2b05e512de7370077d1f1d531dbb9587438d887e and 010b0aa0a865336fb6fb5da92c3aa676c7bbe53d.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* packages/synapse-constants/README.md (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>



<details>
<summary>🪛 Markdownlint</summary><blockquote>

<details>
<summary>packages/synapse-constants/README.md</summary><blockquote>

19-19: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</blockquote></details>

</blockquote></details>

</details>

<details>
<summary>🔇 Additional comments (1)</summary><blockquote>

<details>
<summary>packages/synapse-constants/README.md (1)</summary><blockquote>

`23-34`: **LGTM! Clear and concise usage examples.**

The updated usage section provides clear and concise examples for importing supported tokens and chains, as well as importing a specific token. The examples consistently use the new package name.

</blockquote></details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

packages/synapse-constants/README.md Show resolved Hide resolved
Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 010b0aa
Status: ✅  Deploy successful!
Preview URL: https://0c238376.sanguine-fe.pages.dev
Branch Preview URL: https://synapse-constants-update-rea.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.76937%. Comparing base (2b05e51) to head (010b0aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3268         +/-   ##
===================================================
+ Coverage   30.68788%   31.76937%   +1.08148%     
===================================================
  Files            447         427         -20     
  Lines          29787       28496       -1291     
  Branches          82          82                 
===================================================
- Hits            9141        9053         -88     
+ Misses         19797       18597       -1200     
+ Partials         849         846          -3     
Flag Coverage Δ
packages 90.43902% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abtestingalpha abtestingalpha merged commit 174911d into master Oct 10, 2024
38 checks passed
@abtestingalpha abtestingalpha deleted the synapse-constants/update-readme branch October 10, 2024 17:55
Copy link

codecov bot commented Oct 10, 2024

Bundle Report

Changes will increase total bundle size by 348.81kB (1.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@synapsecns/synapse-constants-esm-cjs 174.63kB 174.63kB (100%) ⬆️
@synapsecns/synapse-constants-cjs-esm 174.18kB 174.18kB (100%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant