fix withdrawal api [SLT-365]

[trajan0x]

Description

Summary by CodeRabbit

• New Features
  • Simplified handling of gas token transactions in the withdrawal process.
• Bug Fixes
  • Improved reliability of the withdrawal method by removing unnecessary checks.

[coderabbitai]

Walkthrough

The changes focus on the Withdraw method within the Handler struct in services/rfq/relayer/relapi/handler.go. The primary modification involves the removal of a conditional check for the gas price of the transactor, allowing for a more straightforward transaction submission logic for gas tokens. While the overall structure, error handling, and validation processes remain intact, the internal logic for handling gas tokens has been simplified. There are no changes to the method's signature or public entity declarations.

Changes

File Path	Change Summary
services/rfq/relayer/relapi/handler.go	Simplified transaction submission logic in Withdraw method by removing gas price conditional check.

Possibly related PRs

• rfq: mimimal viable withdrawal api #2815: Modifies the Withdraw function in the same handler.go file, adding new functionality for token withdrawals.
• [rfq] add withdraw tracing #2929: Introduces tracing functionality in the Withdraw method, aligning with the focus on improving withdrawal logic.
• docs(rfq): withdrawal CLI documentation #3012: Documents the new withdrawal CLI command and associated API endpoint, directly related to the improved withdrawal functionality.

Suggested labels

size/m

Suggested reviewers

• aureliusbtc
• dwasse

🐰 In the meadow where bunnies play,
A simpler path has come our way.
With tokens now, we swiftly glide,
No checks to slow our joyful ride.
Hooray for changes, bright and clear,
In the world of code, we cheer and cheer! 🌼

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f55ce0a and ae5a3ca.

📒 Files selected for processing (1)

• services/rfq/relayer/relapi/handler.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• services/rfq/relayer/relapi/handler.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.01524%. Comparing base (6880ddd) to head (ae5a3ca).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6880ddd) and HEAD (ae5a3ca). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (6880ddd)	HEAD (ae5a3ca)
solidity	2	0

Additional details and impacted files

@@                 Coverage Diff                  @@
##              master       #3306          +/-   ##
====================================================
- Coverage   44.38046%   25.01524%   -19.36522%     
====================================================
  Files            137         198          +61     
  Lines           5383       13124        +7741     
  Branches         356          82         -274     
====================================================
+ Hits            2389        3283         +894     
- Misses          2979        9556        +6577     
- Partials          15         285         +270     

Flag	Coverage Δ
opbot	0.48870% <ø> (ø)
promexporter	6.81642% <ø> (ø)
rfq	24.63468% <100.00000%> (?)
solidity	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cloudflare-workers-and-pages]

Deploying sanguine-fe with    Cloudflare Pages

Latest commit:	ae5a3ca
Status:	✅  Deploy successful!
Preview URL:	https://d7eeed49.sanguine-fe.pages.dev
Branch Preview URL:	https://fix-gas-price-reset.sanguine-fe.pages.dev

View logs